Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751336AbeAPExz (ORCPT + 1 other); Mon, 15 Jan 2018 23:53:55 -0500 Received: from ozlabs.org ([103.22.144.67]:51235 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbeAPExy (ORCPT ); Mon, 15 Jan 2018 23:53:54 -0500 Date: Tue, 16 Jan 2018 15:53:47 +1100 From: David Gibson To: Michael Ellerman Cc: Michal Suchanek , Benjamin Herrenschmidt , Paul Mackerras , Philippe Ombredanne , =?iso-8859-1?Q?C=E9dric?= Le Goater , Thomas Falcon , "Tobin C. Harding" , Michael Neuling , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h Message-ID: <20180116045347.GC30352@umbus.fritz.box> References: <20180115133003.3447-1-msuchanek@suse.de> <87wp0ia3x1.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TYecfFk8j8mZq+dy" Content-Disposition: inline In-Reply-To: <87wp0ia3x1.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --TYecfFk8j8mZq+dy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 16, 2018 at 02:16:58PM +1100, Michael Ellerman wrote: > Michal Suchanek writes: >=20 > > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > > settings") uses u64 in asm/hvcall.h without including linux/types.h > > > > This breaks hvcall.h users that do not include the header themselves. > > > > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > > settings") > > > > Signed-off-by: Michal Suchanek > > --- > > arch/powerpc/include/asm/hvcall.h | 1 + > > 1 file changed, 1 insertion(+) >=20 > Thanks. None of my ~250 defconfig test builds hit this, what config are > you using? I also hit this, but only when I backported the change to RH's 3.10 kernel. I assumed something since then had added an indirect include. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TYecfFk8j8mZq+dy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlpdhVgACgkQbDjKyiDZ s5KqAg/+P8wx2xAgvydHMrfHQR67hwejhtnyLgonYe5tiVBQXN4/XOUFP4rDCClP OVF/OcPl2oQz6hRGoZaz6YZvoq3zzpL/Glxa5Z2+tE4RRXvzy8zAGrJz1GxXmUli LS22iO7Y+Bnkj2y89q98j0yJjboFm3rlyuto8uoeWdQhIKj+KwL+Z4n/wgwH6/sO Q0xpvus1FKIbDP9QqjRe+te+mdMOmGgHpI3NWr0gk1Qzs8J+KDiBNXo7leE8k2Vh qAKxRGA8c+iWDqltOYk2iC6yr/8o1nuBVIjd+icLQ0cChHsxsQZnzj9D3dHVSSqJ Ye59pPe3zBNKgJ2H7E4hLsKqwTfWTOb9dQKM+IKaXaaK1gkAAUBhBn+PNwQJRGeW xGgFLZr1kKqvPGLw3M/C6VsHtbZUmVxUIztAVGT+Edspv16YHjB/G5FR1g1ViNZi LO/BYK3yHW3oJ1PqHvaGLVGmFTeB8LDmvA2cRSzUrprYkalF+yqMavCJ2QgWvynS j81xUDqM6zzmYIe6TllBvjcsRIp5GK4KlmmzpN4kMkpbFUv9b7oKfmE/m/UMr+TO U9UGT/b0LqRvf+s2oKZgUbtbhApt5rvbfF8Gkkv37hbWsNSF9CEZRgQIfx6pC+Dh E5fvczBOx7/bODMTwD5HSi2nvbD83W4LGOjUH0qbxUKFUqmmqq4= =1UZh -----END PGP SIGNATURE----- --TYecfFk8j8mZq+dy--