Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750892AbeAPH0T (ORCPT + 1 other); Tue, 16 Jan 2018 02:26:19 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:36101 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbeAPH0R (ORCPT ); Tue, 16 Jan 2018 02:26:17 -0500 Date: Mon, 15 Jan 2018 23:26:15 -0800 From: Christoph Hellwig To: Eric Wheeler Cc: drbd-dev@lists.linbit.com, Eric Wheeler , Eric Wheeler , stable@vger.kernel.org, Philipp Reisner , Lars Ellenberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drbd: fix discard_zeroes_if_aligned regression Message-ID: <20180116072615.GA3940@infradead.org> References: <15124635.GA4107@soda.linbit> <1516057231-21756-1-git-send-email-drbd-dev@lists.ewheeler.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516057231-21756-1-git-send-email-drbd-dev@lists.ewheeler.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: NAK. Calling a discard and expecting zeroing is simply buggy. And double NAK for patches like this without a linux-block Cc.