Subject: Re: [PATCH] soc: xilinx: xlnx_vcu: Depends on HAS_IOMEM for xlnx_vcu
To: Dhaval Shah <dhaval.shah@xilinx.com>, <michal.simek@xilinx.com>,
        <pombredanne@nexb.com>, <tglx@linutronix.de>,
        <kstewart@linuxfoundation.org>, <gregkh@linuxfoundation.org>
CC: <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, Dhaval Shah <dshah@xilinx.com>
References: <201801141754.lROQHRMR%fengguang.wu@intel.com>
 <1516084488-16372-1-git-send-email-dshah@xilinx.com>
From: Michal Simek <michal.simek@xilinx.com>
Message-ID: <162bd4c1-6125-f856-85b1-6ee2d69ac7ec@xilinx.com>
Date: Tue, 16 Jan 2018 08:35:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1516084488-16372-1-git-send-email-dshah@xilinx.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 07:35:36.7705
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea1b77c-2861-44ab-aa69-08d55cb3bc40
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1334
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 16.1.2018 07:34, Dhaval Shah wrote:
> xlnx_vcu driver uses devm_ioremap_nocache, which is included
> only when HAS_IOMEM is enabled.
> 
> drivers/soc/xilinx/xlnx_vcu.o: In function `xvcu_probe':
>    xlnx_vcu.c:(.text+0x116): undefined reference to `devm_ioremap_nocache'
>    xlnx_vcu.c:(.text+0x1ae): undefined reference to `devm_ioremap_nocache'
> 
> Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> ---
>  drivers/soc/xilinx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/xilinx/Kconfig b/drivers/soc/xilinx/Kconfig
> index 266b50f..bf657ab 100644
> --- a/drivers/soc/xilinx/Kconfig
> +++ b/drivers/soc/xilinx/Kconfig
> @@ -3,6 +3,7 @@ menu "Xilinx SoC drivers"
>  
>  config XILINX_VCU
>          tristate "Xilinx VCU logicoreIP Init"
> +	depends on HAS_IOMEM
>          help
>            Provides the driver to enable and disable the isolation between the
>            processing system and programmable logic part by using the logicoreIP
> 


Applied.

Thanks,
Michal