Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751113AbeAPIMJ (ORCPT + 1 other); Tue, 16 Jan 2018 03:12:09 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:43186 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbeAPIMH (ORCPT ); Tue, 16 Jan 2018 03:12:07 -0500 Date: Tue, 16 Jan 2018 09:12:04 +0100 From: Steffen Klassert To: Nicolas Dichtel CC: David Miller , , , Subject: Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find."" Message-ID: <20180116081203.inf3ye7jmnejfdkr@gauss3.secunet.de> References: <20180115123415.325497625@linuxfoundation.org> <20180115123418.624941321@linuxfoundation.org> <20180115132328.cuwcmhb262z2psgl@gauss3.secunet.de> <20180115.115612.281197218565244967.davem@davemloft.net> <20180116063339.cvslencknccrbs73@gauss3.secunet.de> <0f075b61-5b5d-9055-6664-82df2d316d0c@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f075b61-5b5d-9055-6664-82df2d316d0c@6wind.com> User-Agent: NeoMutt/20170609 (1.8.3) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 8E308D01-9D5F-4422-A1DC-F840BA04A82B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 08:44:41AM +0100, Nicolas Dichtel wrote: > Le 16/01/2018 ? 07:33, Steffen Klassert a ?crit?: > > > > Maybe you started to look again into this because Nicolas Dichtel > > (Cced) asked to queue this patch on Jan 5, the patch was already > > in the stable tree (Jan 4) but probably not in an actual release > > at this time. > Oh, I didn't find it at this time in the linux-stable tree nor in the stable > patchwork. Bad timing :/ > > I still don't find it in the patchwork: > http://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=1442&state=*&q=&archive=both > Am I missing something? Not so sure which patches are included here, maybe just the ones that still needs to be submitted to stable. Anyway, the commit we need is included in v4.14.12: commit 2d01ac8cc12b973668bf898b03bf9ffb12d83b83 Author: Steffen Klassert Date: Wed, 15 Nov 2017 06:40:57 +0100 Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find." commit 94802151894d482e82c324edf2c658f8e6b96508 upstream. This reverts commit c9f3f813d462c72dbe412cee6a5cbacf13c4ad5e. This commit breaks transport mode when the policy template has widlcard addresses configured, so revert it. Signed-off-by: Steffen Klassert Cc: From: Derek Robson Signed-off-by: Greg Kroah-Hartman > > > > >> > >> We can drop this, but you need to then tell us whether 4.14 needs > >> the revert any longer and if so what the correct SHA ID would > >> be. > > > > I think we can we can just drop this. > > > > Unless Nicolas knows something that is still missing, v4.14.12 and > > above should be ok as is. > I agree, we can drop this. Ok, so let's drop it. Thanks!