Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751101AbeAPIoY (ORCPT + 1 other); Tue, 16 Jan 2018 03:44:24 -0500 Received: from mail-pl0-f48.google.com ([209.85.160.48]:35620 "EHLO mail-pl0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbeAPIoX (ORCPT ); Tue, 16 Jan 2018 03:44:23 -0500 X-Google-Smtp-Source: ACJfBotzL1Vj4S+r23kqVW99u5iTJwCQQTUxwlw+fetbK2qX0LnqpOmoLfKX7BoW4/KZqVxaGzJ86Q== Date: Tue, 16 Jan 2018 14:14:20 +0530 From: Viresh Kumar To: Eduardo Valentin Cc: Zhang Rui , Vincent Guittot , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs Message-ID: <20180116084420.GI22978@vireshk-i7> References: <087186fecdfd85bead58e110cf8bf7ccdfab517b.1515663078.git.viresh.kumar@linaro.org> <20180112174606.GA11076@localhost.localdomain> <20180115044616.GC22978@vireshk-i7> <20180115163221.GA3756@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180115163221.GA3756@localhost.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 15-01-18, 08:32, Eduardo Valentin wrote: > On Mon, Jan 15, 2018 at 10:16:16AM +0530, Viresh Kumar wrote: > > No because I am exiting early for same sates in that routine. > > Did I miss that hunk? Yes. It is something like this. + if (stats->state == new_state) + goto unlock; + -- viresh