Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbeAPJSY (ORCPT + 1 other); Tue, 16 Jan 2018 04:18:24 -0500 Received: from smtps.newmedia-net.de ([185.84.6.167]:42400 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750798AbeAPJSW (ORCPT ); Tue, 16 Jan 2018 04:18:22 -0500 Subject: Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports To: Kevin Cernekee Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable , Andrew Lunn , "David S. Miller" References: <20180101140056.475827799@linuxfoundation.org> <20180101140100.858496151@linuxfoundation.org> <9edf97da-5492-b598-492e-c982591dddff@dd-wrt.com> From: Sebastian Gottschall Message-ID: <76522cb7-8a6e-8379-6850-33c8f6943f99@dd-wrt.com> Date: Tue, 16 Jan 2018 10:18:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > According to my understanding of igmpv3_newpack(), the destination > address should always be IGMPV3_ALL_MCR = 224.0.0.22. That is what I > see in my testing. > > However, your packet trace says 239.35.100.8. I don't know how the > code that we touched would be generating an IGMPv2 packet with that > destination address. easy answer from wikipedia. 224.0.x.x is not the only multicast block 224.0.0.0 to 224.0.0.255 Local subnetwork 224.0.1.0 to 224.0.1.255 Internetwork control 224.0.2.0 to 224.0.255.255 AD-HOC block 1 224.3.0.0 to 224.4.255.255 AD-HOC block 2 232.0.0.0 to 232.255.255.255 Source-specific multicas 233.0.0.0 to 233.251.255.255 GLOP addressing 233.252.0.0 to 233.255.255.255 AD-HOC block 3 234.0.0.0 to 234.255.255.255 Unicast-prefix-based 239.0.0.0 to 239.255.255.255 Administratively scoped > Would it be possible to get a stack trace for the case where the > source address is being cleared to 0.0.0.0 in your configuration? you mean something like dumpstack and watching the flood comes over me? -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565