Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbeAPJVb (ORCPT + 1 other); Tue, 16 Jan 2018 04:21:31 -0500 Received: from smtps.newmedia-net.de ([185.84.6.167]:52494 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750812AbeAPJV3 (ORCPT ); Tue, 16 Jan 2018 04:21:29 -0500 Subject: Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports To: Kevin Cernekee Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable , Andrew Lunn , "David S. Miller" References: <20180101140056.475827799@linuxfoundation.org> <20180101140100.858496151@linuxfoundation.org> <9edf97da-5492-b598-492e-c982591dddff@dd-wrt.com> From: Sebastian Gottschall Message-ID: Date: Tue, 16 Jan 2018 10:21:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: in addition 224.0.0.x is not routable. all other multicast addresses i showed you are routable. so your code  will filter valid multicast origins since they arent present on local interfaces. looks like your code only works valid for 224.0.0.x addresses but not any other valid multicast address -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565