Date: Tue, 16 Jan 2018 10:44:27 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
        Ladislav Michl <ladis@linux-mips.org>,
        Roger Quadros <rogerq@ti.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Sebastian Reichel <sre@kernel.org>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: onenand: omap2: print resource using %pR format
 string
Message-ID: <20180116104427.33f55027@bbrezillon>
In-Reply-To: <20180116074359.2861596-1-arnd@arndb.de>
References: <20180116074359.2861596-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 16 Jan 2018 08:43:40 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> The omap2 onenand driver is now available for compile-testing, which
> uncovers a warning in configurations that have a 64-bit resource_size_t:
> 
> drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
> drivers/mtd/onenand/omap2.c:536:54: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>    dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
> drivers/mtd/onenand/omap2.c:536:66: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> 
> Changing the format string to the special %pR simplifies the code
> and lets it do the right thing in that configuration, while avoiding
> the warning.
> 

Applied. I'll adjust my PR to include this fix.

Thanks,

Boris

> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/mtd/onenand/omap2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 2ce73fb6da1c..a4a2159bcfb7 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -533,8 +533,7 @@ static int omap2_onenand_probe(struct platform_device *pdev)
>  
>  	c->onenand.base = devm_ioremap_resource(dev, res);
>  	if (IS_ERR(c->onenand.base)) {
> -		dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
> -			res->start, resource_size(res));
> +		dev_err(dev, "Cannot reserve memory region %pR\n", res);
>  		return PTR_ERR(c->onenand.base);
>  	}
>