Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbeAPLRp (ORCPT + 1 other); Tue, 16 Jan 2018 06:17:45 -0500 Received: from foss.arm.com ([217.140.101.70]:53098 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbeAPLRo (ORCPT ); Tue, 16 Jan 2018 06:17:44 -0500 Date: Tue, 16 Jan 2018 11:17:40 +0000 From: Catalin Marinas To: Punit Agrawal Cc: kvmarm@lists.cs.columbia.edu, suzuki.poulose@arm.com, Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC 1/4] arm64: Correct type for PUD macros Message-ID: <20180116111740.tn6qy7yjs2d5ltx6@armageddon.cambridge.arm.com> References: <20180110190729.18383-1-punit.agrawal@arm.com> <20180110190729.18383-2-punit.agrawal@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110190729.18383-2-punit.agrawal@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 07:07:26PM +0000, Punit Agrawal wrote: > The PUD macros (PUD_TABLE_BIT, PUD_TYPE_MASK, PUD_TYPE_SECT) use the > pgdval_t even when pudval_t is available. Even though the underlying > type for both (u64) is the same it is confusing and may lead to issues > in the future. > > Fix this by using pudval_t to define the PUD_* macros. > > Fixes: 084bd29810a56 ("ARM64: mm: HugeTLB support.") > Fixes: 206a2a73a62d3 ("arm64: mm: Create gigabyte kernel logical mappings where possible") > Signed-off-by: Punit Agrawal > Cc: Catalin Marinas > Cc: Will Deacon I queued this patch. I'll leave the KVM bits to Marc/Christoffer. -- Catalin