Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbeAPMEh (ORCPT + 1 other); Tue, 16 Jan 2018 07:04:37 -0500 Received: from verein.lst.de ([213.95.11.211]:47202 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbeAPMEf (ORCPT ); Tue, 16 Jan 2018 07:04:35 -0500 Date: Tue, 16 Jan 2018 13:04:33 +0100 From: Christoph Hellwig To: Jeff Moyer Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 32/32] aio: implement io_pgetevents Message-ID: <20180116120433.GA14579@lst.de> References: <20180110155853.32348-1-hch@lst.de> <20180110155853.32348-33-hch@lst.de> <20180115085310.GB32532@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180115085310.GB32532@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 09:53:10AM +0100, Christoph Hellwig wrote: > > pselect, as an example, crams the sigmask and size together. Why not > > just do that? libaio can take care of setting that up. > > Yes, I could try that. It's just another double indirection for no > good reason. I cna't get this to work - for some reason I always end up with a NULL sigmask in the kernel. Nevermind that it leads to really crap code generation. I guess for select the latter doesn't matter too much as everyone sane uses ppoll anyway.