Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbeAPN2m (ORCPT + 1 other); Tue, 16 Jan 2018 08:28:42 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51113 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbeAPN2h (ORCPT ); Tue, 16 Jan 2018 08:28:37 -0500 X-ME-Sender: Subject: Re: [PATCH] ALSA: pcm: Fix trailing semicolon To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Joe Perches , Jaroslav Kysela , Takashi Sakamoto References: <20180115181857.32105-1-luisbg@kernel.org> From: Luis de Bethencourt Message-ID: <9f26c3ec-75fe-2dce-05ee-a26fea0bcfd6@kernel.org> Date: Tue, 16 Jan 2018 13:28:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/15/2018 07:18 PM, Takashi Iwai wrote: > On Mon, 15 Jan 2018 19:18:57 +0100, > Luis de Bethencourt wrote: >> >> From: Ubuntu > > Is this from address intentional? It'd be taken as is via git-am. > > > thanks, > > Takashi > >> The trailing semicolon is an empty statement that does no operation. >> Removing it since it doesn't do anything. >> >> Signed-off-by: Luis de Bethencourt >> --- >> >> >> Hi, >> >> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches >> suggested I fix it treewide [0]. >> >> Best regards >> Luis >> >> >> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html >> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html >> >> sound/core/pcm_native.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c >> index 3f13e8da0812..51104df924e1 100644 >> --- a/sound/core/pcm_native.c >> +++ b/sound/core/pcm_native.c >> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap); >> int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream, >> struct vm_area_struct *area) >> { >> - struct snd_pcm_runtime *runtime = substream->runtime;; >> + struct snd_pcm_runtime *runtime = substream->runtime; >> >> area->vm_page_prot = pgprot_noncached(area->vm_page_prot); >> return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes); >> -- >> 2.15.1 >> >> Hi Takashi, Sorry. Not sure how git send-email added that line to the commit message. I have sent a v2 correcting it. Thanks, Luis