Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbeAPOBH (ORCPT + 1 other); Tue, 16 Jan 2018 09:01:07 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41187 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbeAPOBF (ORCPT ); Tue, 16 Jan 2018 09:01:05 -0500 Subject: Re: [PATCH v8 3/5] can: m_can: Move allocation of net device to probe From: Marc Kleine-Budde To: Faiz Abbas , wg@grandegger.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, nsekhar@ti.com, fcooper@ti.com, robh@kernel.org, Wenyou.Yang@microchip.com, sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org, b29396@freescale.com References: <1516102634-6771-1-git-send-email-faiz_abbas@ti.com> <1516102634-6771-4-git-send-email-faiz_abbas@ti.com> Message-ID: <1dcb2038-cc6d-44e5-fe51-e43041b1fe5f@pengutronix.de> Date: Tue, 16 Jan 2018 15:00:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n61MLG9MW0N4Qg60qaYOVa0GuRCAnzRkg" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n61MLG9MW0N4Qg60qaYOVa0GuRCAnzRkg Content-Type: multipart/mixed; boundary="eKhm3KutavnApDCimxe8BCvzsjJ3n29ig"; protected-headers="v1" From: Marc Kleine-Budde To: Faiz Abbas , wg@grandegger.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, nsekhar@ti.com, fcooper@ti.com, robh@kernel.org, Wenyou.Yang@microchip.com, sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org, b29396@freescale.com Message-ID: <1dcb2038-cc6d-44e5-fe51-e43041b1fe5f@pengutronix.de> Subject: Re: [PATCH v8 3/5] can: m_can: Move allocation of net device to probe References: <1516102634-6771-1-git-send-email-faiz_abbas@ti.com> <1516102634-6771-4-git-send-email-faiz_abbas@ti.com> In-Reply-To: --eKhm3KutavnApDCimxe8BCvzsjJ3n29ig Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 01/16/2018 02:03 PM, Marc Kleine-Budde wrote: >> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_c= an.c >> index 893edbb..ebb74de 100644 >> --- a/drivers/net/can/m_can/m_can.c >> +++ b/drivers/net/can/m_can/m_can.c >> @@ -1207,25 +1207,20 @@ static bool m_can_niso_supported(const struct = m_can_priv *priv) >> return !niso_timeout; >> } >> =20 >> -static struct net_device *alloc_m_can_dev(struct platform_device *pde= v, >> - void __iomem *addr, u32 tx_fifo_size) >> +static int setup_m_can_dev(struct platform_device *pdev, struct net_d= evice *dev, >> + void __iomem *addr) >=20 > Renamed to m_can_dev_setup() for consistent namespace. And removed free_m_can_dev(), by calling free_candev() directly. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --eKhm3KutavnApDCimxe8BCvzsjJ3n29ig-- --n61MLG9MW0N4Qg60qaYOVa0GuRCAnzRkg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE4bay/IylYqM/npjQHv7KIOw4HPYFAlpeBXkACgkQHv7KIOw4 HPZJuwf/Z1tL2ijIV92dXMyr5IJMB6yPrb7ZbmcDxR2QBi1blKG/M8aDm9kvsHQs a53i7popXcyD4K9sH5FxL91L1AcGdGdAx0t04XpZizCK4FsWrNt1mGPB4Ir7YftZ ynJOZmCFEWUpvyJeB2S9r/EattQK3w/QbYHKYGl3KyV/uFt1fFDskptJDcGc1YA9 dgWjWCbaQgeLzbADwnaUD8tPNBEcsBeAnrHI4E+J6c0n5jC42fIvwR+MArer5qrx ZbUN26xdf027Vd26cM7Q9Hz0lMxfydKCgnTW5q0tTLJ6IqZBv9uuBiz7C9/ALqIl fBhRT2XjFC/tH/uPi8hZs1ra4xUrZA== =d7NX -----END PGP SIGNATURE----- --n61MLG9MW0N4Qg60qaYOVa0GuRCAnzRkg--