Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbeAPPTY (ORCPT + 1 other); Tue, 16 Jan 2018 10:19:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30857 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbeAPPTX (ORCPT ); Tue, 16 Jan 2018 10:19:23 -0500 Date: Tue, 16 Jan 2018 16:19:15 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Ingo Molnar , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Hendrick Brueckner , Namhyung Kim , Thomas Richter , Wang Nan Subject: Re: [PATCH 2/5] perf unwind: Do not look at globals Message-ID: <20180116151915.GC17819@krava> References: <20180116142438.19520-1-acme@kernel.org> <20180116142438.19520-3-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116142438.19520-3-acme@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 16 Jan 2018 15:19:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 11:24:35AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > Cc: Adrian Hunter > Cc: David Ahern > Cc: Hendrick Brueckner > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Thomas Richter > Cc: Wang Nan > Link: https://lkml.kernel.org/n/tip-skbth8ufepbtw8xar7gdsb6l@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/util/unwind-libunwind-local.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c > index 7a42f703e858..02dc5a9d8f72 100644 > --- a/tools/perf/util/unwind-libunwind-local.c > +++ b/tools/perf/util/unwind-libunwind-local.c > @@ -631,9 +631,6 @@ static unw_accessors_t accessors = { > > static int _unwind__prepare_access(struct thread *thread) > { > - if (callchain_param.record_mode != CALLCHAIN_DWARF) > - return 0; > - this would create thread->addr_space also for data without dwarf callchains data, so I think we need to keep it it should get set in apply_config_terms which calls parse_callchain_record once it detects some 'call-graph' term setup.. something's probably wrong there? jirka > thread->addr_space = unw_create_addr_space(&accessors, 0); > if (!thread->addr_space) { > pr_err("unwind: Can't create unwind address space.\n"); > @@ -646,17 +643,11 @@ static int _unwind__prepare_access(struct thread *thread) > > static void _unwind__flush_access(struct thread *thread) > { > - if (callchain_param.record_mode != CALLCHAIN_DWARF) > - return; > - > unw_flush_cache(thread->addr_space, 0, 0); > } > > static void _unwind__finish_access(struct thread *thread) > { > - if (callchain_param.record_mode != CALLCHAIN_DWARF) > - return; > - > unw_destroy_addr_space(thread->addr_space); > } > > -- > 2.14.3 >