Date: Tue, 16 Jan 2018 07:31:39 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: "Liu, Changcheng" <changcheng.liu@intel.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: remove redundant nxttail index marco define
Reply-To: paulmck@linux.vnet.ibm.com
References: <20180116090514.GA5706@sofia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180116090514.GA5706@sofia>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-Id: <20180116153139.GV9671@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jan 16, 2018 at 05:05:14PM +0800, Liu, Changcheng wrote:
> rcu nxttail has been optimized to be rcu_segcblist.
> The index has been defined in linux/rcu_segcblist.h
> 
> Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>

Good eyes!  Applied for testing and review.

							Thanx, Paul

> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 46a5d19..78cb5f3 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -185,13 +185,6 @@ union rcu_noqs {
>  	u16 s; /* Set of bits, aggregate OR here. */
>  };
> 
> -/* Index values for nxttail array in struct rcu_data. */
> -#define RCU_DONE_TAIL		0	/* Also RCU_WAIT head. */
> -#define RCU_WAIT_TAIL		1	/* Also RCU_NEXT_READY head. */
> -#define RCU_NEXT_READY_TAIL	2	/* Also RCU_NEXT head. */
> -#define RCU_NEXT_TAIL		3
> -#define RCU_NEXT_SIZE		4
> -
>  /* Per-CPU data for read-copy update. */
>  struct rcu_data {
>  	/* 1) quiescent-state and grace-period handling : */
> -- 
> 2.7.4
>