Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbeAPPkc (ORCPT + 1 other); Tue, 16 Jan 2018 10:40:32 -0500 Received: from smtps.newmedia-net.de ([185.84.6.167]:57813 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751126AbeAPPk2 (ORCPT ); Tue, 16 Jan 2018 10:40:28 -0500 Subject: Re: [PATCH 4.9 27/75] net: igmp: Use correct source address on IGMPv3 reports To: Kevin Cernekee Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable , Andrew Lunn , "David S. Miller" References: <20180101140056.475827799@linuxfoundation.org> <20180101140100.858496151@linuxfoundation.org> <9edf97da-5492-b598-492e-c982591dddff@dd-wrt.com> <76522cb7-8a6e-8379-6850-33c8f6943f99@dd-wrt.com> From: Sebastian Gottschall Message-ID: Date: Tue, 16 Jan 2018 16:40:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: >> easy answer from wikipedia. 224.0.x.x is not the only multicast block > AFAICT the code that was changed by this patch should not have > anything to do with other multicast blocks. It generates an IGMPv3 > report with destination address 224.0.0.22. So it would be useful to > get more information on how exactly it is causing a failure, so we can > find the root cause. from your code it always returns 0.0.0.0 and not the correct origin if your rule doesnt match. this is a different behaviour. before, the origin was used as is and not modified. if the origin is set to zero, the routing of the network doesnt work anymore. this works for local multicast addresses, but not for neighbor networks which are using the routing table but correct me if i'm wrong -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565