Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751031AbeAPQZ0 (ORCPT + 1 other); Tue, 16 Jan 2018 11:25:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbeAPQZY (ORCPT ); Tue, 16 Jan 2018 11:25:24 -0500 Reply-To: mchristi@redhat.com Subject: Re: [PATCH] tcmu: Fix trailing semicolon To: Luis de Bethencourt , linux-kernel@vger.kernel.org Cc: Joe Perches , "Nicholas A . Bellinger" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org References: <20180116153432.17927-1-luisbg@kernel.org> From: Michael Christie Organization: Red Hat Message-ID: Date: Tue, 16 Jan 2018 10:25:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180116153432.17927-1-luisbg@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 16 Jan 2018 16:25:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/16/2018 09:34 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > It is completely stripped out by the compiler. Removing it since it doesn't do > anything. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches > suggested I fix it treewide [0]. > > Best regards > Luis > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > drivers/target/target_core_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c > index 60c8a87b7a88..f6164d294fb3 100644 > --- a/drivers/target/target_core_user.c > +++ b/drivers/target/target_core_user.c > @@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev) > > wake_up_all(&udev->nl_cmd_wq); > > - return ret;; > + return ret; > } > > static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd, > Acked-by: Mike Christie