Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbeAPRso (ORCPT + 1 other); Tue, 16 Jan 2018 12:48:44 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:40222 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbeAPRsm (ORCPT ); Tue, 16 Jan 2018 12:48:42 -0500 X-Google-Smtp-Source: ACJfBoswX7fXlyGcU7g/CQe2NQVClTK1skY3b7cdo9aMs6gcaQFSbQVDlFFp6DLt6+Tn5ltURqdu0A== Date: Tue, 16 Jan 2018 09:48:38 -0800 From: Stephen Hemminger To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Joe Perches , netdev@vger.kernel.org, "David S . Miller" Subject: Re: [PATCH] vxlan: Fix trailing semicolon Message-ID: <20180116094839.0775faf2@xeon-e3> In-Reply-To: <20180116150332.11242-1-luisbg@kernel.org> References: <20180116150332.11242-1-luisbg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, 16 Jan 2018 15:03:32 +0000 Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > It is completely stripped out by the compiler. Removing it since it doesn't do > anything. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > An other trailing semicolon to remove. > > Best regards > Luis > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > include/net/vxlan.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/vxlan.h b/include/net/vxlan.h > index f96391e84a8a..ad73d8b3fcc2 100644 > --- a/include/net/vxlan.h > +++ b/include/net/vxlan.h > @@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb, > l4_hdr = ipv6_hdr(skb)->nexthdr; > break; > default: > - return features;; > + return features; > } > > if ((l4_hdr == IPPROTO_UDP) && Fixes: 5f35227ea34b ("net: Generalize ndo_gso_check to ndo_features_check") Acked-by: Stephen Hemminger