Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbeAPRzW (ORCPT + 1 other); Tue, 16 Jan 2018 12:55:22 -0500 Received: from mail-vk0-f67.google.com ([209.85.213.67]:34407 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbeAPRzU (ORCPT ); Tue, 16 Jan 2018 12:55:20 -0500 X-Google-Smtp-Source: ACJfBoszRSoJdkdasibyaN9Zmej6A79K2x+ZLwQhZD2fSEe68lCzSwYOBeJFLQa2W+imKCEVEOIovvbElOuMm9FNsaY= MIME-Version: 1.0 In-Reply-To: <20180116132129.11340-1-luisbg@kernel.org> References: <20180116132129.11340-1-luisbg@kernel.org> From: Kees Cook Date: Tue, 16 Jan 2018 09:55:18 -0800 X-Google-Sender-Auth: iTv99HjBdkd--9DX-4vcFabd918 Message-ID: Subject: Re: [PATCH] modpost: Remove trailing semicolon To: Luis de Bethencourt Cc: LKML , Joe Perches , Jessica Yu , Ingo Molnar , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 5:21 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Yup, good. Signed-off-by: Kees Cook -Kees > --- > > Hi, > > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches > suggested I fix it treewide [0]. > > Best regards > Luis > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > scripts/mod/modpost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index f51cf977c65b..49dfcd556c78 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -1685,7 +1685,7 @@ static void extable_mismatch_handler(const char* modname, struct elf_info *elf, > static void check_section_mismatch(const char *modname, struct elf_info *elf, > Elf_Rela *r, Elf_Sym *sym, const char *fromsec) > { > - const char *tosec = sec_name(elf, get_secindex(elf, sym));; > + const char *tosec = sec_name(elf, get_secindex(elf, sym)); > const struct sectioncheck *mismatch = section_mismatch(fromsec, tosec); > > if (mismatch) { > -- > 2.15.1 > -- Kees Cook Pixel Security