Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbeAPT6q (ORCPT + 1 other); Tue, 16 Jan 2018 14:58:46 -0500 Received: from mail-ot0-f170.google.com ([74.125.82.170]:41530 "EHLO mail-ot0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbeAPT6p (ORCPT ); Tue, 16 Jan 2018 14:58:45 -0500 X-Google-Smtp-Source: ACJfBos+1yHqpKZ3L0zddJC3ty8hvejR3tHId37op6A79AA/CiQL2XjShO3dYT3EyXh5OgAbPE7KY60KXwZWTneUKG4= MIME-Version: 1.0 In-Reply-To: <1dc0e4ce-2190-eb83-166f-b8ba7cdacede@ozlabs.org> References: <20180116170053.2557047-1-arnd@arndb.de> <1dc0e4ce-2190-eb83-166f-b8ba7cdacede@ozlabs.org> From: Arnd Bergmann Date: Tue, 16 Jan 2018 20:58:44 +0100 X-Google-Sender-Auth: zAO6t5dRbwUaifePUlrYD6u70YE Message-ID: Subject: Re: [PATCH] [RESEND] spufs: use timespec64 for timestamps To: Jeremy Kerr Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Al Viro , Andrew Morton , linuxppc-dev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 8:07 PM, Jeremy Kerr wrote: > Hi Arnd, > >> The switch log prints the tv_sec portion of timespec as a 32-bit >> number, while overflows in 2106. It also uses the timespec type, >> which is safe on 64-bit architectures, but deprecated because >> it causes overflows in 2038 elsewhere. >> >> This changes it to timespec64 and printing a 64-bit number for >> consistency. > > If we still have spufs in the tree in 2038 I'd be worried :) Agreed. My hope is to get rid of 'timespec' in 2018 though, this is just one of many parts of the puzzle. Arnd