Date: Tue, 16 Jan 2018 22:24:16 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
cc: dwmw@amazon.co.uk, torvalds@linux-foundation.org,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        arjan.van.de.ven@intel.com, peterz@infradead.org,
        Andi Kleen <ak@linux.intel.com>, jeyu@kernel.org
Subject: Re: [PATCH v2] retpoline/module: Warn for missing retpoline in
 module
In-Reply-To: <20180116205956.4tdbdilcmxykdtf4@two.firstfloor.org>
Message-ID: <alpine.DEB.2.20.1801162223410.2366@nanos>
References: <20180112221323.3304-1-andi@firstfloor.org> <alpine.DEB.2.20.1801162132410.2366@nanos> <20180116205956.4tdbdilcmxykdtf4@two.firstfloor.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 16 Jan 2018, Andi Kleen wrote:

> Thanks.
> 
> I just sent a v3 that changes the VERMAGIC only, based on Greg's 
> earlier feedback.
> 
> It has the drawbacks that it:
> - refuses loading instead of warns
> - doesn't stop refusing when the feature is runtime disabled
> 
> But it's much simpler, just a few lines of ifdef.
> 
> We can either go with the v3, or rework this one into a v4?

V3 is fine. Not loading is the right thing to do :)

Thanks,

	tglx