Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbeAPWeY (ORCPT + 1 other); Tue, 16 Jan 2018 17:34:24 -0500 Received: from one.firstfloor.org ([193.170.194.197]:51322 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbeAPWeX (ORCPT ); Tue, 16 Jan 2018 17:34:23 -0500 Date: Tue, 16 Jan 2018 14:34:21 -0800 From: Andi Kleen To: Thomas Gleixner Cc: Andi Kleen , torvalds@linux-foundation.org, dwmw@amazon.co.uk, linux-kernel@vger.kernel.org, gregkh@linux-foundation.org, arjan.van.de.ven@intel.com, jeyu@kernel.org, rusty@rustcorp.com.au, Andi Kleen Subject: Re: [PATCH v3] retpoline: Add retpoline tag to VERMAGIC Message-ID: <20180116223421.ntjryg32aaxrhffl@two.firstfloor.org> References: <20180116205228.4890-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 10:24:53PM +0100, Thomas Gleixner wrote: > On Tue, 16 Jan 2018, Andi Kleen wrote: > > > From: Andi Kleen > > > > Add a marker for retpoline to the module VERMAGIC. This catches > > the case when a non RETPOLINE compiled module gets loaded into > > a retpoline kernel, making it insecure. > > > > It doesn't handle the case when retpoline has been runtime disabled. > > Even in this case the match of the retcompile status will be enforced. > > This implies that even with retpoline run time disabled all modules > > loaded need to be recompiled. > > > > This supersedes an earlier patch that did the same checking using > > a new module tag (so it's really a v3) > > > > Signed-off-by: Andi Kleen > > Acked-by: Thomas Gleixner Thanks. Through which tree should this go? Or Linus, could you take it directly? -Andi