Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbeAPXUs (ORCPT + 1 other); Tue, 16 Jan 2018 18:20:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59998 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbeAPXUn (ORCPT ); Tue, 16 Jan 2018 18:20:43 -0500 Subject: [bpf-next PATCH 3/3] libbpf: Makefile set specified permission mode From: Jesper Dangaard Brouer To: netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , wangnan0@huawei.com Cc: jakub.kicinski@netronome.com, joe@ovn.org, linux-kernel@vger.kernel.org, acme@redhat.com, eric@regit.org, Jesper Dangaard Brouer , jolsa@redhat.com Date: Wed, 17 Jan 2018 00:20:40 +0100 Message-ID: <151614484037.20077.13490091259604820524.stgit@firesoul> In-Reply-To: <151614479780.20077.13317825346011334728.stgit@firesoul> References: <151614479780.20077.13317825346011334728.stgit@firesoul> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 16 Jan 2018 23:20:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: The third parameter to do_install was not used by $(INSTALL) command. Fix this by only setting the -m option when the third parameter is supplied. The use of a third parameter was introduced in commit eb54e522a000 ("bpf: install libbpf headers on 'make install'"). Without this change, the header files are install as executables files (755). Fixes: eb54e522a000 ("bpf: install libbpf headers on 'make install'") Signed-off-by: Jesper Dangaard Brouer --- tools/lib/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index 8e15e48cb8f8..83714ca1f22b 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -172,7 +172,7 @@ define do_install if [ ! -d '$(DESTDIR_SQ)$2' ]; then \ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \ fi; \ - $(INSTALL) $1 '$(DESTDIR_SQ)$2' + $(INSTALL) $1 $(if $3,-m $3,) '$(DESTDIR_SQ)$2' endef install_lib: all_cmd