Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751261AbeAPX5A (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 16 Jan 2018 18:57:00 -0500
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36674 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750830AbeAPX47 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jan 2018 18:56:59 -0500
Date: Tue, 16 Jan 2018 15:57:03 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH RFC tip/core/rcu] Make SRCU be once again optional
Reply-To: paulmck@linux.vnet.ibm.com
References: <20170512184155.GA9482@linux.vnet.ibm.com>
 <alpine.LFD.2.20.1705121444260.3061@knanqh.ubzr>
 <20170512191005.GE3956@linux.vnet.ibm.com>
 <20170603035915.GA23375@linux.vnet.ibm.com>
 <alpine.LFD.2.20.1706030102570.17440@knanqh.ubzr>
 <20170603203620.GL3721@linux.vnet.ibm.com>
 <CAK8P3a1AKdSiansYoztQ1GqOUvL8YPAP8HnSGe_gv+wwHk4f4w@mail.gmail.com>
 <20180116223431.GA9671@linux.vnet.ibm.com>
 <CAK8P3a0STk8VU1H-JOGnwiFCGnu5Rqsw8_sddaYLgZCbXShb0Q@mail.gmail.com>
 <CAK8P3a3yrhcWihPtgFu2q-_oY4a4nc6pkc+DqpA7OxE+gMVPEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK8P3a3yrhcWihPtgFu2q-_oY4a4nc6pkc+DqpA7OxE+gMVPEQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-TM-AS-GCONF: 00
x-cbid: 18011623-0052-0000-0000-000002A395E2
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00008391; HX=3.00000241; KW=3.00000007;
 PH=3.00000004; SC=3.00000246; SDB=6.00976061; UDB=6.00494759; IPR=6.00755988;
 BA=6.00005781; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000;
 ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019081; XFM=3.00000015;
 UTC=2018-01-16 23:56:56
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 18011623-0053-0000-0000-000053420AD4
Message-Id: <20180116235703.GD9671@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-16_12:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000
 definitions=main-1801160324
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed, Jan 17, 2018 at 12:03:18AM +0100, Arnd Bergmann wrote:
> On Tue, Jan 16, 2018 at 11:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> >
> > That fixed the first warning for me, doing the same thing for all three
> > fixed the rest
> 
> Now with my workaround applied and the original randconfig that triggered
> the failure, I get another problem:
> 
> drivers/base/power/wakeup.c:68:1: error: data definition has no type
> or storage class [-Werror]
>  DEFINE_STATIC_SRCU(wakeup_srcu);
> 
> Evidently there is at least one driver that uses SRCU but doesn't 'select SRCU'
> in Kconfig. There are probably others that just haven't been found.

Does adding "select SRCU" on "config PM_SLEEP" in kernel/power/Kconfig
fix this?

							Thanx, Paul