Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbeAQFXL (ORCPT + 1 other); Wed, 17 Jan 2018 00:23:11 -0500 Received: from mail-ua0-f195.google.com ([209.85.217.195]:41840 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbeAQFXK (ORCPT ); Wed, 17 Jan 2018 00:23:10 -0500 X-Google-Smtp-Source: ACJfBovMREb0p/AUCzsVlag1V6hYxooatc8a1E6DKrrZ9n0+SzDbDjnM+ytNV7HDQKhmd9omDZCGaA== MIME-Version: 1.0 In-Reply-To: <20180116132540.18939-5-jeffy.chen@rock-chips.com> References: <20180116132540.18939-1-jeffy.chen@rock-chips.com> <20180116132540.18939-5-jeffy.chen@rock-chips.com> From: Tomasz Figa Date: Wed, 17 Jan 2018 14:22:47 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 04/13] iommu/rockchip: Fix error handling in probe To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, Ricky Liang , Robin Murphy , simon xue , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , "open list:IOMMU DRIVERS" , Joerg Roedel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > Add missing iommu_device_sysfs_remove in error path. > > Also adjust sequence of deinit functions in the remove. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None > > drivers/iommu/rockchip-iommu.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > Reviewed-by: Tomasz Figa Best regards, Tomasz