From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Scott Wood <oss@buserror.net>,
        Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address
In-Reply-To: <7341aef1-f2ac-6e9b-8279-93b0f0649b81@c-s.fr>
References: <9a5dadc10f88e2fc0ac9fb5d18c5424df33f3f4c.1515169256.git.christophe.leroy@c-s.fr> <876081by7g.fsf@linux.vnet.ibm.com> <b5e34a5b-94b8-9405-929d-d35dde3fcb3b@c-s.fr> <945affcd-b25c-bc6e-68e5-8bbbcd31c0fd@linux.vnet.ibm.com> <7341aef1-f2ac-6e9b-8279-93b0f0649b81@c-s.fr>
Date: Wed, 17 Jan 2018 10:53:41 +0530
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Message-Id: <87y3kxrrc2.fsf@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org

Christophe LEROY <christophe.leroy@c-s.fr> writes:

>>
>>> How should I split in separate patches ? Something like ?
>>> 1/ Slice support for PPC32 > 2/ Activate slice for 8xx
>> 
>> Yes something like that. Will you  be able to avoid that
>>   if (SLICE_NUM_HIGH) from the code? That makes the code ugly. Right now 
>> i don't have definite suggestion on what we could do though.
>> 
>
> Could use #ifdefs instead, but in my mind it would be even more ugly.
>
> I would have liked just doing nothing, but the issue is that at the 
> moment bitmap_xxx() functions are not prepared to handle bitmaps of size 
> zero. Should we try to change that ? Any chance to succeed ?
>

How much code duplication it is to do slice_32.c?

Michael,

What do you suggest here?

-aneesh