Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbeAQF4A (ORCPT + 1 other); Wed, 17 Jan 2018 00:56:00 -0500 Received: from mga05.intel.com ([192.55.52.43]:49421 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbeAQFz7 (ORCPT ); Wed, 17 Jan 2018 00:55:59 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,371,1511856000"; d="scan'208";a="196293204" Date: Wed, 17 Jan 2018 13:47:38 +0800 From: "Du, Changbin" To: Namhyung Kim Cc: "Du, Changbin" , Steven Rostedt , jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' Message-ID: <20180117054737.ap2jvg5jnfuth4ya@intel.com> References: <1516093350-12045-1-git-send-email-changbin.du@intel.com> <20180116124226.73d2c7e2@gandalf.local.home> <20180117045433.sg2kbbx3x2nqnsoo@intel.com> <20180117054524.GB7530@danjae.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117054524.GB7530@danjae.aot.lge.com> User-Agent: NeoMutt/20171027-42-ad8712 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 17, 2018 at 02:45:24PM +0900, Namhyung Kim wrote: > Hello, > > On Wed, Jan 17, 2018 at 12:54:34PM +0800, Du, Changbin wrote: > > On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote: > > > On Tue, 16 Jan 2018 17:02:27 +0800 > > > changbin.du@intel.com wrote: > > > > > > > From: Changbin Du > > > > > > > > I found there are some problems in the tracing parser when I investiage the root > > > > cause of issues mentioned in below patch. > > > > https://patchwork.kernel.org/patch/10132953/ > > > > > > I pulled in your patches and tweaked the change logs of the other two > > > patches as well. You can see my temporary git tree here, but it may > > > rebase. > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > > > > > > ftrace/core > > > > > > -- Steve > > Got it. Thank you! > > > > Hi Olsa, so the perf patch 'perf ftrace: Fix the buffer size in__write_tracing_file' > > is still needed. I will resend you at appropriate time. > > But it will work on the future kernels only, right? For tools to be > compatible with old kernels, you'd better writing a whitespace after > the function name IMHO. > Yes, it needs to write a space if it doesn't want possible error hidden. > Thanks, > Namhyung -- Thanks, Changbin Du