Date: Wed, 17 Jan 2018 10:55:22 +0200
From: Sakari Ailus <sakari.ailus@iki.fi>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
        laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com,
        geert@glider.be, hverkuil@xs4all.nl, mchehab@kernel.org,
        festevam@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
        pombredanne@nexb.com, linux-renesas-soc@vger.kernel.org,
        linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings
Message-ID: <20180117085522.kfgt6re2rfq4qeun@valkosipuli.retiisi.org.uk>
References: <1516139101-7835-1-git-send-email-jacopo+renesas@jmondi.org>
 <1516139101-7835-2-git-send-email-jacopo+renesas@jmondi.org>
 <20180117075958.ggnk4cmmkdah2am6@valkosipuli.retiisi.org.uk>
 <20180117083553.GF24926@w540>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180117083553.GF24926@w540>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Jan 17, 2018 at 09:35:53AM +0100, jacopo mondi wrote:
> Hi Sakari,
>     it's the second series this week where I fail to handle BT.656
> properly, sorry about this :)

No worries. I guess I forgot your reply. If the hardware doesn't support
Bt.656 then the current definition is fine.

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

> 
> On Wed, Jan 17, 2018 at 09:59:59AM +0200, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > On Tue, Jan 16, 2018 at 10:44:53PM +0100, Jacopo Mondi wrote:
> > > Add bindings documentation for Renesas Capture Engine Unit (CEU).
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> > > ---
> > >  .../devicetree/bindings/media/renesas,ceu.txt      | 81 ++++++++++++++++++++++
> > >  1 file changed, 81 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.txt b/Documentation/devicetree/bindings/media/renesas,ceu.txt
> > > new file mode 100644
> > > index 0000000..590ee27
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/renesas,ceu.txt
> > > @@ -0,0 +1,81 @@
> > > +Renesas Capture Engine Unit (CEU)
> > > +----------------------------------------------
> > > +
> > > +The Capture Engine Unit is the image capture interface found in the Renesas
> > > +SH Mobile and RZ SoCs.
> > > +
> > > +The interface supports a single parallel input with data bus width of 8 or 16
> > > +bits.
> > > +
> > > +Required properties:
> > > +- compatible: Shall be "renesas,r7s72100-ceu" for CEU units found in RZ/A1-H
> > > +  and RZ/A1-M SoCs.
> > > +- reg: Registers address base and size.
> > > +- interrupts: The interrupt specifier.
> > > +
> > > +The CEU supports a single parallel input and should contain a single 'port'
> > > +subnode with a single 'endpoint'. Connection to input devices are modeled
> > > +according to the video interfaces OF bindings specified in:
> > > +Documentation/devicetree/bindings/media/video-interfaces.txt
> > > +
> > > +Optional endpoint properties applicable to parallel input bus described in
> > > +the above mentioned "video-interfaces.txt" file are supported.
> > > +
> > > +- hsync-active: Active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.
> > > +  If property is not present, default is active high.
> > > +- vsync-active: Active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.
> > > +  If property is not present, default is active high.
> >
> > Does the hardware support Bt.656? If it does, you need to tell the
> > difference between the parallel interface with default sync polarity and
> > Bt.656 interfaces. With the above it's ambiguous.
> 
> No, it does not support BT.656.
> 
> I'm listing them as -required- endpoint properties. If they are not
> specified the drivers fails during probe:
> 
>         renesas-ceu e8210000.ceu: Only parallel input supported.
> 
> Thanks
>    j
> 
> >
> > > +
> > > +Example:
> > > +
> > > +The example describes the connection between the Capture Engine Unit and an
> > > +OV7670 image sensor connected to i2c1 interface.
> > > +
> > > +ceu: ceu@e8210000 {
> > > +	reg = <0xe8210000 0x209c>;
> > > +	compatible = "renesas,r7s72100-ceu";
> > > +	interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> > > +
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&vio_pins>;
> > > +
> > > +	status = "okay";
> > > +
> > > +	port {
> > > +		ceu_in: endpoint {
> > > +			remote-endpoint = <&ov7670_out>;
> > > +
> > > +			hsync-active = <1>;
> > > +			vsync-active = <0>;
> > > +		};
> > > +	};
> > > +};
> > > +
> > > +i2c1: i2c@fcfee400 {
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&i2c1_pins>;
> > > +
> > > +	status = "okay";
> > > +
> > > +	clock-frequency = <100000>;
> > > +
> > > +	ov7670: camera@21 {
> > > +		compatible = "ovti,ov7670";
> > > +		reg = <0x21>;
> > > +
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&vio_pins>;
> > > +
> > > +		reset-gpios = <&port3 11 GPIO_ACTIVE_LOW>;
> > > +		powerdown-gpios = <&port3 12 GPIO_ACTIVE_HIGH>;
> > > +
> > > +		port {
> > > +			ov7670_out: endpoint {
> > > +				remote-endpoint = <&ceu_in>;
> > > +
> > > +				hsync-active = <1>;
> > > +				vsync-active = <0>;
> > > +			};
> > > +		};
> > > +	};
> > > +};
> > > --
> > > 2.7.4
> > >
> >
> > --
> > Sakari Ailus
> > e-mail: sakari.ailus@iki.fi

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi