From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
        "marc.zyngier@arm.com" <marc.zyngier@arm.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqdomain: provide useful debugging information for irq
 domain
Thread-Topic: [PATCH] irqdomain: provide useful debugging information for
 irq domain
Thread-Index: AQHTj009Wdh6WNEqvUKYpF9MpLNJq6N3N/6AgAALlACAAAIrgA==
Date: Wed, 17 Jan 2018 09:26:24 +0000
Message-ID: <1516181177.3280.13.camel@hxt-semitech.com>
References: <1516163877-32396-1-git-send-email-shunyong.yang@hxt-semitech.com>
         <210f90d0-1588-2185-4845-d5d143183621@arm.com>
         <alpine.DEB.2.20.1801171018000.1777@nanos>
In-Reply-To: <alpine.DEB.2.20.1801171018000.1777@nanos>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset=US-ASCII
Content-ID: <5A6D589629E01E428DE62A1F40D0B635@hxt-semitech.com>
Content-Transfer-Encoding: 7BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org

Hi, Marc and Thomas,

Thanks for your feedback.

On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote:
> On Wed, 17 Jan 2018, Marc Zyngier wrote:
> > 
> > In all honesty, I'd be more inclined to remove this debug feature
> > altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and more
> > useful. Is there any feature missing from that infrastructure that
> > prevents you from using it instead?
> > 
> > If the answer is "none", then I'll post a patch removing it.
> Wanted to do that quite some time ago and never came around to it.

I think they have different purpose.
irq_domain_mapping is an overiew of the mapping of each virq to hwirq
and the domain it belongs. It likes a map or index of each IRQs. I tend
to suggest to keep it.
The nodes under debugfs irq/domains describes the hierarchy of each irq
domain.
The nodes under debugfs irq/irqs describes information of every single
irq.


Thanks
Shunyong