Date: Wed, 17 Jan 2018 10:33:36 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
cc: "marc.zyngier@arm.com" <marc.zyngier@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqdomain: provide useful debugging information for irq
 domain
In-Reply-To: <1516181177.3280.13.camel@hxt-semitech.com>
Message-ID: <alpine.DEB.2.20.1801171032490.1777@nanos>
References: <1516163877-32396-1-git-send-email-shunyong.yang@hxt-semitech.com>  <210f90d0-1588-2185-4845-d5d143183621@arm.com>  <alpine.DEB.2.20.1801171018000.1777@nanos> <1516181177.3280.13.camel@hxt-semitech.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Wed, 17 Jan 2018, Yang, Shunyong wrote:

> Hi, Marc and Thomas,
> 
> Thanks for your feedback.
> 
> On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote:
> > On Wed, 17 Jan 2018, Marc Zyngier wrote:
> > > 
> > > In all honesty, I'd be more inclined to remove this debug feature
> > > altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and more
> > > useful. Is there any feature missing from that infrastructure that
> > > prevents you from using it instead?
> > > 
> > > If the answer is "none", then I'll post a patch removing it.
> > Wanted to do that quite some time ago and never came around to it.
> 
> I think they have different purpose.
> irq_domain_mapping is an overiew of the mapping of each virq to hwirq
> and the domain it belongs. It likes a map or index of each IRQs. I tend
> to suggest to keep it.

And how is that different from:

> The nodes under debugfs irq/irqs describes information of every single
> irq.

Not at all. It contains the complete hierarchical information of each virq.

Thanks,

	tglx