Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbeAQJz7 (ORCPT + 1 other); Wed, 17 Jan 2018 04:55:59 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:58834 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbeAQJz4 (ORCPT ); Wed, 17 Jan 2018 04:55:56 -0500 Date: Wed, 17 Jan 2018 12:51:30 +0300 From: Dan Carpenter To: Shreeya Patel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 3/4] Staging: rtl8723bs: Change condition to assignment Message-ID: <20180117095129.mylvwsvqbv322kzw@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8776 signatures=668653 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=885 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801170143 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 17, 2018 at 12:33:23AM +0530, Shreeya Patel wrote: > Change the conditional operator to assignment as it is > not a conditional statement. > > Signed-off-by: Shreeya Patel > --- > > Changes in v2 > -Rebase and resend. > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index 00b20c0..314b31f 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -460,7 +460,7 @@ static u32 sdio_read_port( > if (mem == NULL) { > DBG_8192C(KERN_WARNING "%s: allocate memory %d bytes fail!\n", __func__, cnt); > mem = oldmem; > - oldmem == NULL; > + oldmem = NULL; > } > #else This bug would cause a GCC warning if it were ever compiled. This ifdefed code is dead. We should just delete it. regards, dan carpenter