Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbeAQKig (ORCPT + 1 other); Wed, 17 Jan 2018 05:38:36 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:40491 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbeAQKhj (ORCPT ); Wed, 17 Jan 2018 05:37:39 -0500 X-Google-Smtp-Source: ACJfBotQ+8kbp/G8fr3Y91vilDpukpX5yulHZ+5XPHMdpwNr3m7eCdftFwNy6KNoNsua4kQZInjXdg== Subject: Re: [Suspected-Phishing]Re: [PATCH V3 1/2] nvme: split resetting state into reset_prepate and resetting To: "jianchao.wang" , Max Gurtovoy , keith.busch@intel.com, axboe@fb.com, hch@lst.de Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org References: <1515647268-1717-1-git-send-email-jianchao.w.wang@oracle.com> <1515647268-1717-2-git-send-email-jianchao.w.wang@oracle.com> <1c001532-234f-bc56-7fb4-bcd08142842e@mellanox.com> <2d198b6a-47f4-8d2b-024d-76161f4b0f90@oracle.com> From: Sagi Grimberg Message-ID: <538cb758-a343-a823-3a50-993a541414b3@grimberg.me> Date: Wed, 17 Jan 2018 12:37:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2d198b6a-47f4-8d2b-024d-76161f4b0f90@oracle.com> Content-Type: text/plain; charset=windows-1255; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > After Sagi's nvme-rdma: fix concurrent reset and reconnect, the rdma ctrl state is changed to RECONNECTING state > after some clearing and shutdown work, then some initializing procedure, no matter reset work path or error recovery path. > The fc reset work also does the same thing. > So if we define the range that RESET_PREPARE includes scheduling gap and disable and clear work, RESETTING includes initializing > procedure, RECONNECTING is very similar with RESETTING. > > Maybe we could do like this; > In nvme fc/rdma > - set state to RESET_PREPARE, queue reset_work/err_work > - clear/shutdown works, set state to RECONNECTING Should be fine. > In nvme pci > - set state to RESET_PREPARE, queue reset_work > - clear/shutdown works, set state to RESETTING > - initialization, set state to LIVE Given that we split reset state and we have a clear symmetry between the transports, do we want to maybe come up with a unique state that is coherent across all transports? Maybe we rename them to NVME_CTRL_SHUTTING_DOWN and NVME_CTRL_ESTABLISHING? I'm open for better names..