Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbeAQKpO (ORCPT + 1 other); Wed, 17 Jan 2018 05:45:14 -0500 Received: from mga07.intel.com ([134.134.136.100]:28321 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbeAQKpM (ORCPT ); Wed, 17 Jan 2018 05:45:12 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="10792284" Message-ID: <5A5F29C9.4040706@intel.com> Date: Wed, 17 Jan 2018 18:47:37 +0800 From: Wei Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pankaj Gupta CC: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, pbonzini@redhat.com, liliang opensource , yang zhang wz , quan xu0 , nilal@redhat.com, riel@redhat.com Subject: Re: [PATCH v22 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ References: <1516165812-3995-1-git-send-email-wei.w.wang@intel.com> <1516165812-3995-3-git-send-email-wei.w.wang@intel.com> <1003745745.1007975.1516177271163.JavaMail.zimbra@redhat.com> <5A5F109B.7090200@intel.com> <1239524301.1023371.1516181271621.JavaMail.zimbra@redhat.com> In-Reply-To: <1239524301.1023371.1516181271621.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/17/2018 05:27 PM, Pankaj Gupta wrote: >> On 01/17/2018 04:21 PM, Pankaj Gupta wrote: >> > o.k you have initialize "err = -ENOMEM;" > > Remove these four lines. > > - kfree(names); > - kfree(callbacks); > - kfree(vqs); > - return 0; > > + err = 0; // if executed without any error > OK, thanks. "error = 0" is not needed actually. Best, Wei