Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbeAQLE6 (ORCPT + 1 other); Wed, 17 Jan 2018 06:04:58 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:36237 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbeAQLE4 (ORCPT ); Wed, 17 Jan 2018 06:04:56 -0500 Date: Wed, 17 Jan 2018 09:04:49 -0200 From: Mauro Carvalho Chehab To: Matthew Wilcox Cc: Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] Documentation: Fix misconversion of #if Message-ID: <20180117090449.04785d5b@vento.lan> In-Reply-To: <20180117034055.11053-1-willy@infradead.org> References: <20180117034055.11053-1-willy@infradead.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Tue, 16 Jan 2018 19:40:55 -0800 Matthew Wilcox escreveu: > From: Matthew Wilcox > > At some stage of the conversion pipeline, something thought that the > DocBook entity # should be rendered as NUM instead of #. > > Signed-off-by: Matthew Wilcox Reviewed-by: Mauro Carvalho Chehab > --- > Documentation/kernel-hacking/hacking.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kernel-hacking/hacking.rst b/Documentation/kernel-hacking/hacking.rst > index daf3883b2694..5c4d30e81b7f 100644 > --- a/Documentation/kernel-hacking/hacking.rst > +++ b/Documentation/kernel-hacking/hacking.rst > @@ -690,8 +690,8 @@ not provide the necessary runtime environment and the include files are > not tested for it. It is still possible, but not recommended. If you > really want to do this, forget about exceptions at least. > > -NUMif > ------ > +#if > +--- > > It is generally considered cleaner to use macros in header files (or at > the top of .c files) to abstract away functions rather than using \`#if' Thanks, Mauro