Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbeAQLO5 (ORCPT + 1 other); Wed, 17 Jan 2018 06:14:57 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:45658 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbeAQLO4 (ORCPT ); Wed, 17 Jan 2018 06:14:56 -0500 Date: Wed, 17 Jan 2018 12:14:50 +0100 (CET) From: Thomas Gleixner To: David Howells cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] Expand the INIT_SIGNALS and INIT_SIGHAND macros and remove In-Reply-To: <19929.1514903630@warthog.procyon.org.uk> Message-ID: References: <151274828194.9961.4230316917108602662.stgit@warthog.procyon.org.uk> <151274831156.9961.11214505146256879075.stgit@warthog.procyon.org.uk> <19929.1514903630@warthog.procyon.org.uk> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, 2 Jan 2018, David Howells wrote: > Thomas Gleixner wrote: > > > > #define INIT_CPU_TIMERS(s) \ > > ... > > That macro is only used in init_task.c Why not moving it there and get rid > > of the whole macro maze in the header file? > > The reason I didn't get rid of it is that it's got more than one expansion > point. Same for INIT_PREV_CPUTIME and INIT_PID_LINK. Ah, sorry I missed that. So yes, the current patch is fine. Acked-by: Thomas Gleixner