Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbeAQLSK (ORCPT + 1 other); Wed, 17 Jan 2018 06:18:10 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4211 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752452AbeAQLSJ (ORCPT ); Wed, 17 Jan 2018 06:18:09 -0500 From: Wei Yongjun To: Alasdair Kergon , Mike Snitzer CC: Wei Yongjun , , Subject: [PATCH -next] dm crypt: fix error return code in crypt_ctr() Date: Wed, 17 Jan 2018 11:24:26 +0000 Message-ID: <1516188266-143804-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Fix to return error code -ENOMEM from the mempool_create_kmalloc_pool() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/md/dm-crypt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 9fc12f5..45f3acf 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -2740,6 +2740,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv) cc->tag_pool_max_sectors * cc->on_disk_tag_size); if (!cc->tag_pool) { ti->error = "Cannot allocate integrity tags mempool"; + ret = -ENOMEM; goto bad; }