Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752870AbeAQLS6 (ORCPT + 1 other); Wed, 17 Jan 2018 06:18:58 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4213 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752400AbeAQLS4 (ORCPT ); Wed, 17 Jan 2018 06:18:56 -0500 From: Wei Yongjun To: Corey Minyard , Arnd Bergmann , "Greg Kroah-Hartman" , Benjamin Herrenschmidt , Paul Mackerras , "Michael Ellerman" CC: Wei Yongjun , , , , Subject: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe() Date: Wed, 17 Jan 2018 11:25:11 +0000 Message-ID: <1516188311-144227-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/char/ipmi/ipmi_powernv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c index c687c8d..bcf493d 100644 --- a/drivers/char/ipmi/ipmi_powernv.c +++ b/drivers/char/ipmi/ipmi_powernv.c @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev) ipmi->irq = opal_event_request(prop); } - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, - "opal-ipmi", ipmi)) { + rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, + "opal-ipmi", ipmi); + if (rc) { dev_warn(dev, "Unable to request irq\n"); goto err_dispose; }