Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbeAQLXB (ORCPT + 1 other); Wed, 17 Jan 2018 06:23:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbeAQLXA (ORCPT ); Wed, 17 Jan 2018 06:23:00 -0500 Subject: Re: [PATCH 5/6] KVM: s390: wire up seb feature To: Christian Borntraeger , kvm@vger.kernel.org Cc: Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Heiko Carstens , Cornelia Huck , Greg Kroah-Hartman , Jon Masters , Marcus Meissner , Jiri Kosina References: <1516182519-10623-1-git-send-email-schwidefsky@de.ibm.com> <1516182519-10623-6-git-send-email-schwidefsky@de.ibm.com> <4fa9b6fa-40cb-b51e-0aa8-2e21bd93d526@de.ibm.com> From: Paolo Bonzini Message-ID: Date: Wed, 17 Jan 2018 12:22:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <4fa9b6fa-40cb-b51e-0aa8-2e21bd93d526@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 17 Jan 2018 11:23:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > while this is kvm code, my current plan is to submit the "final" > version after review and probably some fixes/renames via Martin > together with the other patches. Are you ok with that? Right now it > seems that the CAP number is still fine. Sure, though there will be a capability introduced by PPC for similar purposes, so check for conflicts. On 17/01/2018 12:18, Christian Borntraeger wrote: > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 2c93cbb..0c18f73 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -421,6 +421,9 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > case KVM_CAP_S390_GS: > r = test_facility(133); > break; > + case KVM_CAP_S390_SEB: > + r = test_facility(82); > + break; > default: > r = 0; Can you add a generic "test facility" capability and ioctl? Paolo