Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbeAQLcf (ORCPT + 1 other); Wed, 17 Jan 2018 06:32:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45400 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbeAQLcc (ORCPT ); Wed, 17 Jan 2018 06:32:32 -0500 Subject: Re: [PATCH 5/6] KVM: s390: wire up seb feature To: Christian Borntraeger , kvm@vger.kernel.org Cc: Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Heiko Carstens , Cornelia Huck , Greg Kroah-Hartman , Jon Masters , Marcus Meissner , Jiri Kosina References: <1516182519-10623-1-git-send-email-schwidefsky@de.ibm.com> <1516182519-10623-6-git-send-email-schwidefsky@de.ibm.com> <4fa9b6fa-40cb-b51e-0aa8-2e21bd93d526@de.ibm.com> <0a8dad23-0d88-cb10-d943-ac9ee265df7f@de.ibm.com> <23083bfd-7fd9-0b03-53ba-fa5f4d46a6b6@de.ibm.com> From: Paolo Bonzini Message-ID: Date: Wed, 17 Jan 2018 12:32:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <23083bfd-7fd9-0b03-53ba-fa5f4d46a6b6@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 17 Jan 2018 11:32:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 17/01/2018 12:29, Christian Borntraeger wrote: >> The problem is not that I announce the facility, I in fact announce that the >> programmatic interface is available (the sebc sync reg and the usage of that field). >> (So the CAP is part of this patch to have both in lockstep) >> A non-existing facility will then just disable that programmatic interface. > To put it differently. CAP_S390_GS and CAP_S390_SEB could also just > do a > > return 1; > > and the QEMU has to check both (which it probably does anyway) I see. Thanks for the explanation! Paolo