Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbeAQNve (ORCPT + 1 other); Wed, 17 Jan 2018 08:51:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbeAQNvc (ORCPT ); Wed, 17 Jan 2018 08:51:32 -0500 From: Jeff Moyer To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 32/32] aio: implement io_pgetevents References: <20180110155853.32348-1-hch@lst.de> <20180110155853.32348-33-hch@lst.de> <20180115085310.GB32532@lst.de> <20180116120433.GA14579@lst.de> <20180117073652.GA27389@lst.de> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 17 Jan 2018 08:51:28 -0500 In-Reply-To: <20180117073652.GA27389@lst.de> (Christoph Hellwig's message of "Wed, 17 Jan 2018 08:36:52 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 17 Jan 2018 13:51:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Christoph Hellwig writes: > On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: >> I'd be willing to bet the issue is in your io_syscall6 implementation. >> You pass in arg5 where arg6 should be used. Don't feel bad, it took me >> the better part of today to figure that out. :) >> >> Here's an incremental diff on top of what you've posted. Feel free to >> fold it into your patch (and format however you like). You can find the >> libaio changes in my 'aio-poll' branch: >> https://pagure.io/libaio/commits/aio-poll >> >> These changes were run through the libaio test harness, 64 bit and 32 >> bit, so the compat system call was tested. > > Oops, yes. Although I prefer the copy_from_user version, this is what > I had: Much cleaner. Thanks! Jeff