Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbeAQOgc (ORCPT + 1 other); Wed, 17 Jan 2018 09:36:32 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:44157 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227AbeAQOg2 (ORCPT ); Wed, 17 Jan 2018 09:36:28 -0500 X-Google-Smtp-Source: ACJfBouOsmZqd0hzo/CJhC0mYwYF4JRO+b++TjsZBnFwPPPuar1CPgbO0/maNiDObLQ1a8HFqp6kyANx9J//bONVMEg= MIME-Version: 1.0 In-Reply-To: <20180117082712.GF2759@phenom.ffwll.local> References: <20180116145720.2348043-1-arnd@arndb.de> <20180117082712.GF2759@phenom.ffwll.local> From: Arnd Bergmann Date: Wed, 17 Jan 2018 15:36:27 +0100 X-Google-Sender-Auth: 4NqFf6jgT5q67bM2aTl06C-2Efw Message-ID: Subject: Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures To: Arnd Bergmann , Patrik Jakobsson , David Airlie , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: >> The two functions pass a partially initialized structure back to the >> caller after a memset() on the destination. >> >> This is not entirely well-defined, most compilers are sensible enough >> to either keep the zero-initialization for the uninitialized members, >> but gcc-4.4 does not, and it warns about this: >> >> drivers/gpu/drm/gma500/oaktrail_crtc.c: In function 'mrst_sdvo_find_best_pll': >> drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.vco' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.dot' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.p2' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.m2' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.m1' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c: In function 'mrst_lvds_find_best_pll': >> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.p' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.vco' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.p2' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.m2' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.m1' may be used uninitialized in this function >> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.n' may be used uninitialized in this function >> >> This adds an initialization at declaration time to avoid the warning >> and make it well-defined on all compiler versions. >> >> Signed-off-by: Arnd Bergmann > > Applied to drm-misc-next-fixes for 4.16, thx for your patch. Thanks! > Aside: Still don't want commit rights? :-) I think I'm fine without. While I do tend to have a backlog on DRM patches that I'd like to get merged, they are generally of the kind that I should not apply myself without the maintainer being involved in some form, and then they can commit it themselves. Arnd