Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbeAQP2f (ORCPT + 1 other); Wed, 17 Jan 2018 10:28:35 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:32685 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbeAQP2d (ORCPT ); Wed, 17 Jan 2018 10:28:33 -0500 Subject: Re: [PATCH] IIO: ADC: stm32-dfsdm: remove unused variable To: Arnd Bergmann , Mark Brown CC: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Maxime Coquelin , Alexandre Torgue , , , References: <20180117144644.2302131-1-arnd@arndb.de> From: Arnaud Pouliquen Message-ID: <8dd30c35-011c-1d0f-7331-76df8fcd0c23@st.com> Date: Wed, 17 Jan 2018 16:27:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180117144644.2302131-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG4NODE1.st.com (10.75.127.10) To SFHDAG3NODE1.st.com (10.75.127.7) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-17_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Arnd, On 01/17/2018 03:46 PM, Arnd Bergmann wrote: > A cleanup left one variable behind that is no longer needed and > can be removed, as shown by the gcc warning: > > drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': > drivers/iio/adc/stm32-dfsdm-core.c:245:29: error: unused variable 'of_id' [-Werror=unused-variable] > > Fixes: abaca806fd13 ("IIO: ADC: stm32-dfsdm: code optimization") > Signed-off-by: Arnd Bergmann > --- > drivers/iio/adc/stm32-dfsdm-core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 84277bcc465f..6290332cfd3f 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); > static int stm32_dfsdm_probe(struct platform_device *pdev) > { > struct dfsdm_priv *priv; > - const struct of_device_id *of_id; > const struct stm32_dfsdm_dev_data *dev_data; > struct stm32_dfsdm *dfsdm; > int ret; > Could you crosscheck? This is included in the patch: https://www.spinics.net/lists/arm-kernel/msg628841.html applied in Mark's branches ( commit abaca806fd13afd069e04e883de8ec75924b0598) Regards Arnaud