Received: by 10.223.148.5 with SMTP id 5csp6021310wrq; Wed, 17 Jan 2018 08:28:31 -0800 (PST) X-Google-Smtp-Source: ACJfBotRv5kVuRBZuWhT1ciHfP0iDFJg4u3UTmv3HTkI9bp44YHSbV3tr6hOHqFEGXSS6GhpxG9m X-Received: by 10.101.69.141 with SMTP id o13mr17210070pgq.204.1516206511119; Wed, 17 Jan 2018 08:28:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516206511; cv=none; d=google.com; s=arc-20160816; b=X8i1LWLnwLKi9QItx02bvOMv2GNbpNvx11QYuzEJM4sqq41uHbmMRqO6p4ldhFjLGO UpGp9DPJiTFiQiY+EAidbQn/cDNOjnfTq+tptLpm8Gf9yxfsZm4xaLE2jv9IL2KunMAO DLOr1rPTJcfA8iuZ/SnF92x/hSytpwlavt7pCU4BJAycpHF+8LXtZJ+/9BHqFPN3PJuY F3hrTF79OTI8u2HgTty/tCJ/8oXkg54ethcjaDK6cL6Hx9NdSLWx5BjIvImW5Gs1KXNU E3LwPJSWYyaKlrFnkWmkLid3DBje7kl/o1o8UwQxzIHW/IDTQlmniMR8r9ksSiSDE2VA zjxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dmarc-filter:dkim-signature :dkim-signature:arc-authentication-results; bh=TkLNH64Z9Kkt4QwdvMZukKpU7Lt8SEqmbIHE8UjTEc4=; b=vGIph4fwscsQihiRWXcGhMF/K6lkRGoMAJR24c1qemHI+FPX17LMhiUfVeXXPcoVox QNZI9Vrake6DUr0X1H43nPOyaH+y/O1rWMux9crBwyG4Mzs0vDMeslxu4xBugD2Iek4v hkM97d+j8vnpPQ8oaziIWaSMU++uRaa5axIZR+p4nL6F65oySqeHdxtAHOMhg0To54uh +72jTzC4gwtZXBHQhxvy84o2jo/A8wOK4/wiBU+vNSDoh/hBGWuzq7mZrpYM4afiyzxV n8cVDhBbcuMF1lo+Uzvzt9XDBOLYduKl7ll8CAdsW7omjmu+d3jR6Gw3f7sIAB9/KCV8 7PyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r88si4608018pfl.392.2018.01.17.08.28.16; Wed, 17 Jan 2018 08:28:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; dkim=pass header.i=@codeaurora.org header.s=default header.b=T6PzH6XA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbeAQQ1p (ORCPT + 99 others); Wed, 17 Jan 2018 11:27:45 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59832 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbeAQQ1n (ORCPT ); Wed, 17 Jan 2018 11:27:43 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C9463608BF; Wed, 17 Jan 2018 16:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1516206462; bh=bxapVNANkqr0RdieH3h7QNAkv7dC6Qb7c+x+eK4UXs8=; h=Subject:To:References:From:Date:In-Reply-To:From; b=T6PzH6XAhuKi/4P60IG9d5Hv47a72mGucz8h9ZPLKg7vJg4cLilGzj881YcJqU8AV SMktf2yaAHC6zut6lQ8VcEJJsDegEhQ7PSiii/QVOmPo05ccQYP5HUAL942DNyDphh lIpKYKn/yly9uoFimUQ/7sdIMjC+nJhJq4ek7BSY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.48.245.156] (global_nat1.qualcomm.com [129.46.96.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CE10960115; Wed, 17 Jan 2018 16:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1516206462; bh=bxapVNANkqr0RdieH3h7QNAkv7dC6Qb7c+x+eK4UXs8=; h=Subject:To:References:From:Date:In-Reply-To:From; b=T6PzH6XAhuKi/4P60IG9d5Hv47a72mGucz8h9ZPLKg7vJg4cLilGzj881YcJqU8AV SMktf2yaAHC6zut6lQ8VcEJJsDegEhQ7PSiii/QVOmPo05ccQYP5HUAL942DNyDphh lIpKYKn/yly9uoFimUQ/7sdIMjC+nJhJq4ek7BSY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CE10960115 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event To: Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-5-git-send-email-poza@codeaurora.org> From: Sinan Kaya Message-ID: Date: Wed, 17 Jan 2018 11:27:39 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516185438-31556-5-git-send-email-poza@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/2018 5:37 AM, Oza Pawandeep wrote: > +static bool dpc_wait_link_active(struct pci_dev *pdev) > +{ I think you can also make this function common instead of making another copy here. Of course, this would be another patch. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.