Received: by 10.223.148.5 with SMTP id 5csp6033406wrq; Wed, 17 Jan 2018 08:35:53 -0800 (PST) X-Google-Smtp-Source: ACJfBosxYdVH9xi0wRxNox//jalgSW4PrY7e1UCb3PvJtnCzeHU2J+n1Qnzo5yIHMFZeWSz/5A3e X-Received: by 10.84.128.100 with SMTP id 91mr42740204pla.71.1516206953289; Wed, 17 Jan 2018 08:35:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516206953; cv=none; d=google.com; s=arc-20160816; b=EPybvWedIzLm28+8KmOCPOl8YnLcyTbQ4TvxsQ8w1ZHt+gk8SnwCtF145/1/VQcVk4 TtJuevg5MxWfFHOPfb/bFN3j1EeBDwhOTUcplGqZa/b76uTUUSLuGk2Qys38hL0NBTAj zke7z5BcEKbiHiu+Fqk8hqh8fQHUVCY0gKYg6eey9F4NkTxIdDpSkQU37O2d76+12JoQ yWdXSWIVc4uJERFW45ZukbDg9OF4blr3/ySmKH4OmgFU+hRPhV18Wbe+g4l/UpvfFGv4 Y0CfUt74NLBsoXDEEajQXRXfFywfZzCXtpWEzDlZGq+LMXG+liEn2yqLUgKH82MFgnJQ YuDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date:arc-authentication-results; bh=ZtpKesfEooJcaVSAFS98RPh56HzjiFpJ1TrtqONG69M=; b=f3LKEWT3zl1bdUi33fT2UEE/OLKtBohdVdyimHmoV1Tb6cAHssCY5VIvsa8fUbZc0W c1LMN37XnzQM628S1M34lkR3vi7O4ARaFquD0bnl3umqhRphImNr4ceJFzrn2PlvEsgr bSi/8Sc0pIqoTCXRgcDERIWzINMDYn6pSIP2ud2zPC7gJ+UMdPnCOIF+m/S7/VmOltxD aY8+FEMela0nk/mrgEEF9LgLB0ExpaaxDCD1Mgl/V00mOFKaVNf+M4Fo+b6TwtIiYWlm yNZ/llfQoDk4W6dpal0jSYV0oyn4OFe2EOj+AK9rPiNa2IYrc5pKY6ju4lY8rutOueyS XsSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5si4254040plo.443.2018.01.17.08.35.38; Wed, 17 Jan 2018 08:35:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545AbeAQQeu (ORCPT + 99 others); Wed, 17 Jan 2018 11:34:50 -0500 Received: from terminus.zytor.com ([65.50.211.136]:36279 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754007AbeAQQes (ORCPT ); Wed, 17 Jan 2018 11:34:48 -0500 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTP id w0HGVWBI000819; Wed, 17 Jan 2018 08:31:32 -0800 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id w0HGVW2A000816; Wed, 17 Jan 2018 08:31:32 -0800 Date: Wed, 17 Jan 2018 08:31:32 -0800 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Taeung Song Message-ID: Cc: namhyung@kernel.org, treeze.taeung@gmail.com, hpa@zytor.com, akpm@linux-foundation.org, acme@redhat.com, tglx@linutronix.de, mingo@kernel.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org Reply-To: mingo@kernel.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, treeze.taeung@gmail.com, hpa@zytor.com, akpm@linux-foundation.org, acme@redhat.com, tglx@linutronix.de In-Reply-To: <1493218540-12296-1-git-send-email-treeze.taeung@gmail.com> References: <20180112004823.012918807@goodmis.org> <1493218540-12296-1-git-send-email-treeze.taeung@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial() Git-Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 Gitweb: https://git.kernel.org/tip/806efaed3cacab1521895d20bb3b5ed610909299 Author: Taeung Song AuthorDate: Thu, 11 Jan 2018 19:47:50 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:22:57 -0300 tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial() Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if the trivial type is FALSE, it will also run into the TRUE case, and always be skipped as the TRUE statement will continue the loop on the inverse condition of the FALSE statement. Reported-by: Namhyung Kim Acked-by: Namhyung Kim Signed-off-by: Taeung Song Cc: Andrew Morton Link: http://lkml.kernel.org/r/20180112004823.012918807@goodmis.org Link: http://lkml.kernel.org/r/1493218540-12296-1-git-send-email-treeze.taeung@gmail.com Signed-off-by: Steven Rostedt Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/parse-filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 2410afd..2b9048f 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter, case FILTER_TRIVIAL_FALSE: if (filter_type->filter->boolean.value) continue; + break; case FILTER_TRIVIAL_TRUE: if (!filter_type->filter->boolean.value) continue;