Received: by 10.223.148.5 with SMTP id 5csp6037623wrq; Wed, 17 Jan 2018 08:38:28 -0800 (PST) X-Google-Smtp-Source: ACJfBouHFyF4wXGsOgSi+2HboE0QPhf3/j4YyfpIecVRziaSjcbw0w6jMi/BibUarj2OES0LFetO X-Received: by 10.159.194.138 with SMTP id y10mr22181933pln.341.1516207108469; Wed, 17 Jan 2018 08:38:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516207108; cv=none; d=google.com; s=arc-20160816; b=Fgi2JiIyBXxj0PDcDpIXOITjD/t7Qjldf5YKj85BiaZeIkGh3Ghfe27Cdm0xPlISOX jQW7FRNg6C9qaSpGtH9pFvljyK9QhnGBn6WB8juWXi1sI430VMsHmmPHwDyqq8sZFDQ7 En7zTDUtmgJuP7U1GuFqsbxAMdFWjH7qW7wAKNR5Exeqc6dqxI/D+ammAaeilyC+zY88 Ymd+RJ3CZuU/ll+AvpQBUFZHgfc39CXYpLCEwtwj1xkZHQi0XD1CXxzsNtCG7cqWzRdB O083pNwz58JW8wxTWv9OJDY/KzQCAaFe0d0GD2M7/0ph95QXD11a8t7LotjwLO/KSTEa S2rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=Th3RJtY+xakhYkyM+ifSOT3GThY30XMae8oPNHxOySQ=; b=C7Oc4WZL0w7UDYcU4FWDYvs5l7JtVy9cwGnEbO85p30TSiFqaACjFT6G/13zvisSZn mi4EkX2XcbNJXOAtegX6wgaK0Yk8Qwp9Kex21EJN8zpAR5FOJRFoTgMGhChQDu+N1eWu u+adXfx13GAu4F5CsUECuKosUhCDjHZhg4uEKDLPZFCSv7TUn+WgcSrlNCKJrXSpVyT/ vDBkVRmnP9TDXz4WASz7sHRbG6jYVW8f0DuzZjkaJ3j1sUC3JHI6mroOW4S8H0iGgFIB t8tsfuavBGQ1guJjV7jxAxrH0QvVdEbc2OhqhY9wu5hkkvyr2csLhi5G/weU7G0rfout BjSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ui7AsqT/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g67si4104205pgc.690.2018.01.17.08.38.13; Wed, 17 Jan 2018 08:38:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ui7AsqT/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754404AbeAQQhl (ORCPT + 99 others); Wed, 17 Jan 2018 11:37:41 -0500 Received: from mail-wr0-f179.google.com ([209.85.128.179]:45538 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117AbeAQQhh (ORCPT ); Wed, 17 Jan 2018 11:37:37 -0500 Received: by mail-wr0-f179.google.com with SMTP id 16so19539491wry.12 for ; Wed, 17 Jan 2018 08:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Th3RJtY+xakhYkyM+ifSOT3GThY30XMae8oPNHxOySQ=; b=Ui7AsqT//bDhaD/mrN5cfGjohOnW8onAbrPKeKERNse47bVQFeA3S3wk7DD5e1jlwR rB01CRzyW8Dj7JMkTY/AxPfp7klOYdohfQ/0boOGHhW67joqkY0jpGVhR2+CC/aVrhrK qJo+k2v/+HE684y/OraBYxyNzB7o8WEm9eXck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Th3RJtY+xakhYkyM+ifSOT3GThY30XMae8oPNHxOySQ=; b=liqhzl/XDaAhHsOvbyd5u56gzrXYgRmXjwcPyy4gc0dn5aqwXeGDn2i75b35rO1u/1 TH7iFrhmUDq1Jgizu1OriCRwG4etiUUwLOVmfiFvuFL062DCakpa9Me2sv1Xba5lgZCG 0AwhQCFmD3jrBVQ1m/pMEzdO/GxffYd+FllyDcG9LZmVIIk396N30dsEzGD66j31qdUx sXv2J9P1xEpoDsY7GgvF68pZBMrjN+hjOaC5rApbqbWfrimHYM8gnUTvlpy2Aib/NGyD eYh4uIY7CRbS/9LBt1+DPWJ5xNBE8Jscz1E6Nu7fkZiNj5Mhi4UxFZhOu/DSPJ4pqGTK YaPw== X-Gm-Message-State: AKwxytfgc/LvWWLXqLL2Nv+jZiOzYw5ItLpwAoRtBgDR5cBJAqEKNcY6 Cs3jhCIEsl3/H37xnvUz3kxtKQ== X-Received: by 10.223.134.45 with SMTP id 42mr3241095wrv.218.1516207056321; Wed, 17 Jan 2018 08:37:36 -0800 (PST) Received: from [192.168.1.24] (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id p21sm3456310wmc.45.2018.01.17.08.37.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jan 2018 08:37:35 -0800 (PST) Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state To: Emil Velikov , Daniel Vetter Cc: DRI Development , LKML , Jingoo Han , Daniel Vetter , Lee Jones References: <20180117140159.27611-1-daniel.vetter@ffwll.ch> <20180117140159.27611-2-daniel.vetter@ffwll.ch> From: Daniel Thompson Message-ID: Date: Wed, 17 Jan 2018 16:37:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/01/18 14:36, Emil Velikov wrote: > On 17 January 2018 at 14:01, Daniel Vetter wrote: >> Nothing in the entire tree ever sets this, which means this is dead >> code. Remove it. >> >> Cc: Lee Jones >> Cc: Daniel Thompson >> Cc: Jingoo Han >> Signed-off-by: Daniel Vetter >> --- >> drivers/video/backlight/generic_bl.c | 5 ----- > > Fly-by comment, while waiting for coffee to kick-in. > I think this patch should be after pandora/others have stopped abusing > BL_CORE_DRIVER1. You sure? I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver should influence another independent driver. Daniel.