Received: by 10.223.148.5 with SMTP id 5csp6178892wrq; Wed, 17 Jan 2018 10:22:41 -0800 (PST) X-Google-Smtp-Source: ACJfBov+FATR9jt5avACdB29btfpaPSqTxH8vRIEJcG8/DmFdcYnRXbUpojrRrbi3KY0a6kJae17 X-Received: by 10.98.50.5 with SMTP id y5mr38999877pfy.60.1516213361677; Wed, 17 Jan 2018 10:22:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516213361; cv=none; d=google.com; s=arc-20160816; b=OuBU2GOlmrusfZC3luHQXKzTKySjKj5JdXw9YS86tpDUiDIKXmf5djZ46Kzu3xX0+Y F2UKbnWaRtPDqwWn/JCp/zfMd+6lHk5epN1UM/p1O6l150PgL0I7RQbS3ebA3kfjJde3 XK3gE6s9NtUPKWJZUDx9HA6ZMMugN9+LmGlCoEejTp4Fnmcbj7Ivgbpca3+5qETYLfpG F5FT15xtT7VUG4vpwvl/OBbK5T/iHiVty/b6NwIcWzcwBw3/03kqwlwEX73ZZPgLyhLt N9gRbqMKyc4ztvdxEUXh8WvJ2g8YV53FjPCkDbohN51+DLfmLXCfMUdRSmgw63Lc2sWb DtWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:arc-authentication-results; bh=nzohwWWSP5Yrk4Z93RIXYMAy2KzHUN63linFvVRS93w=; b=UjkkS7FAbngLFPtSJyhU6xaCnYHvWmv3pgEzk1ZikZKD0w0c9Dj3vy3BrqPj8RrxFS jBsddttpOzTgMuqiRlOYkHaUtmPoAqPSSqWFmziRAfJXCWJs4Ver/JdB8+a5f5Erc/Xd xGV0Jmdkv2Z4k+fUi+SHO5EGQT/oEY4Wtbaa6Q5Jf00sijbsLwrnPTuVqiTmIUyDuYsM oul6JX6Ie557Q4NVOe8orVUXJjQGTVUiYIvdnk8AGRRkuQoJRYcZOjjS7fo+HtH+E0jw bAFwa2obSuQb3tKNrj9pzRGu3y/iKV6nwL0waPTUnr385HVmIHjkgU8iaEVu19snZ3PP 9OvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b73si5004306pli.441.2018.01.17.10.22.26; Wed, 17 Jan 2018 10:22:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823AbeAQSVw (ORCPT + 99 others); Wed, 17 Jan 2018 13:21:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:56016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641AbeAQSVv (ORCPT ); Wed, 17 Jan 2018 13:21:51 -0500 Received: from localhost (unknown [69.55.156.246]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF5B521742; Wed, 17 Jan 2018 18:21:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF5B521742 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 17 Jan 2018 12:21:49 -0600 From: Bjorn Helgaas To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Joe Perches , Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH] PCI / PM: Fix trailing semicolon Message-ID: <20180117182149.GB7039@bhelgaas-glaptop.roam.corp.google.com> References: <20180117103321.24414-1-luisbg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117103321.24414-1-luisbg@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Rafael] On Wed, Jan 17, 2018 at 10:33:21AM +0000, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Acked-by: Bjorn Helgaas Rafael, I have nothing queued for pci-driver.c, and you've merged most of the recent changes there. If you have any pending changes to it, feel free to merge this one. Otherwise, I'll be happy to pick it up. I would change the subject to: PCI / PM: Remove spurious semicolon > --- > > Hi, > > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches > suggested I fix it treewide [0]. > > Best regards > Luis > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > drivers/pci/pci-driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > index d79dbc377b9c..5958c8dda4e3 100644 > --- a/drivers/pci/pci-driver.c > +++ b/drivers/pci/pci-driver.c > @@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev) > if (dev_pm_smart_suspend_and_suspended(dev)) > return 0; > > - return pm_generic_freeze_late(dev);; > + return pm_generic_freeze_late(dev); > } > > static int pci_pm_freeze_noirq(struct device *dev) > -- > 2.15.1 >