Received: by 10.223.148.5 with SMTP id 5csp6194623wrq; Wed, 17 Jan 2018 10:32:59 -0800 (PST) X-Google-Smtp-Source: ACJfBotjTPPJ1bN2q4yZnjhRIGpaZXF38H0Q808glByIm17gucr5PPF8wlhoYKI2ULGPipB+nR8m X-Received: by 10.98.11.17 with SMTP id t17mr2392184pfi.201.1516213979713; Wed, 17 Jan 2018 10:32:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516213979; cv=none; d=google.com; s=arc-20160816; b=d5VKF0DzbhLA98bKCfWf2Vc2BFwWDNUAgNXJSTUc3kXvCtSU3yZzxItCa754hEXYWI PA/cLrSNNQXrZE5dAtRavHHDrAN177aO+RdNfvtMpGPFFA2eQCnDyaNTRYvwXcyc4MpX j8+fipzzFqAX1NBJFXbe+xn1O6bE0idVKe2tPPqkGyYMFp+ex+nA2X2CKpaKRZzODHDu 5fHeMAOxyKkLuteFHfhTLPprj30fhs3f+rInERYHrgQ0LjO7O+Xm44LoFBX6p+gPPrV7 IRSBR0bTGdjPhmEAokiPOEFj+zy1mPxWqF4x2/RbzSzNW1Y2+S36oOPvgjNNiEkcQqu0 9f4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=nrcaNgzvwALWQAUkFBlWKa/PLTMbknbCEemddoQzgfg=; b=ltfZmglxIbfdZcfgQ0XlAK/XLT3N3Cm4qNvYnGiidv9gCQk4R9vKRbD9t5qXGVSV3E YqfREqqdxIF6/m/qjN6PFSqCwbSYH0DiZ3n0dUcZntvb9fLq4wg8tr/52MeZ/n+lcQtm lO0weQ+vHgnPXRCKggCIYwzdkxuSKfftpOJV23aEbMNSsMqHwAzWShTkzKhdvweOBCLI EqEdwI3R1TM4KJ9TdPDoFqLqIuPmRfKILtFgNtsl0Z3zR0KSw67RJZtaL9J+4XoMx6Jv QCC31tL+XiDuhghlio+nb2HCzXL5QTozbba4sSG5A9rm2Ws5sKe9mWlQHTQbP9QIY441 D36Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=fiE4AHkC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k78si4731813pfk.142.2018.01.17.10.32.45; Wed, 17 Jan 2018 10:32:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=fiE4AHkC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932068AbeAQSbn (ORCPT + 99 others); Wed, 17 Jan 2018 13:31:43 -0500 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]:32378 "EHLO smtp-fw-6002.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754372AbeAQSbm (ORCPT ); Wed, 17 Jan 2018 13:31:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1516213901; x=1547749901; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nrcaNgzvwALWQAUkFBlWKa/PLTMbknbCEemddoQzgfg=; b=fiE4AHkCjVW4CcxL9XPQdg55CAmJTU5jKe0Ng2lQQpatj5n4rPxyGZZn ziUHX6hoPO0mJ1XY0t09YHwe/NXYC7MorrCbTqmhPAIjfQe/uFDNyc+cd DiH7htz+KCtSV6m5lTY65WyIcLSznyRzKEqvDHJ+GHOOB2IMG0SJECHud g=; X-IronPort-AV: E=Sophos;i="5.46,372,1511827200"; d="scan'208";a="327707695" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Jan 2018 18:30:48 +0000 Received: from u54e1ad5160425a4b64ea.ant.amazon.com (iad1-ws-svc-lb91-vlan3.amazon.com [10.0.103.150]) by email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id w0HIUhib071530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Jan 2018 18:30:46 GMT Received: from u54e1ad5160425a4b64ea.ant.amazon.com (localhost [127.0.0.1]) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id w0HIUgZV014915; Wed, 17 Jan 2018 19:30:42 +0100 Received: (from karahmed@localhost) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Submit) id w0HIUgRk014912; Wed, 17 Jan 2018 19:30:42 +0100 From: KarimAllah Ahmed To: linux-pci@vger.kernel.org Cc: KarimAllah Ahmed , Bjorn Helgaas , linux-kernel@vger.kernel.org, =?UTF-8?q?Jan=20H=20=2E=20Sch=C3=B6nherr?= Subject: [PATCH] pci: Do not read INTx PIN and LINE registers for virtual functions Date: Wed, 17 Jan 2018 19:30:29 +0100 Message-Id: <1516213829-14844-1-git-send-email-karahmed@amazon.de> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... since INTx is not supported by-spec for virtual functions. Cc: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: KarimAllah Ahmed Signed-off-by: Jan H. Schönherr --- drivers/pci/probe.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 65099d0..61002fb 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1232,6 +1232,13 @@ static void pci_read_irq(struct pci_dev *dev) { unsigned char irq; + /* Virtual functions do not have INTx support */ + if (dev->is_virtfn) { + dev->pin = 0; + dev->irq = 0; + return; + } + pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &irq); dev->pin = irq; if (irq) -- 2.7.4