Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Jan 2018 20:23:01 +0100
From:   Joerg Roedel <joro@8bytes.org>
To:     Marc Zyngier <marc.zyngier@arm.com>
Cc:     Robin Murphy <robin.murphy@arm.com>,
        Nate Watterson <nwatters@codeaurora.org>,
        Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Sinan Kaya <okaya@codeaurora.org>
Subject: Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure
 message
Message-ID: <20180117192301.GV28161@8bytes.org>
References: <1516214399-24012-1-git-send-email-nwatters@codeaurora.org>
 <2f651cfe-e006-cf1d-b624-08e2ba5340fc@arm.com>
 <66706458-d971-be9b-4390-80a9be39248c@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66706458-d971-be9b-4390-80a9be39248c@arm.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:

> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
> 
> Thoughts?

That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.


	Joerg