Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Jan 2018 19:55:28 +0000
From:   James Hogan <james.hogan@mips.com>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
CC:     <ralf@linux-mips.org>, <linux-kernel@vger.kernel.org>,
        <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
Message-ID: <20180117195527.GZ27409@jhogan-linux.mipstec.com>
References: <20180117185638.22426-1-clabbe.montjoie@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="CRrRoVXEpX/Dc4YP"
Content-Disposition: inline
In-Reply-To: <20180117185638.22426-1-clabbe.montjoie@gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--CRrRoVXEpX/Dc4YP
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> not exists.
> Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> Note that BMIP_GENERIC do the same which confirm that this patch is
> needed.
>=20
> Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board su=
pport")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Good spot:
Reviewed-by: James Hogan <jhogan@kernel.org>

Probably worthy of a backport too:
Cc: <stable@vger.kernel.org> # 4.9+

Cheers
James

> ---
>  arch/mips/Kconfig | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 13c6e5cb6055..504e78ff0b00 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -119,12 +119,12 @@ config MIPS_GENERIC
>  	select SYS_SUPPORTS_MULTITHREADING
>  	select SYS_SUPPORTS_RELOCATABLE
>  	select SYS_SUPPORTS_SMARTMIPS
> -	select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> -	select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> -	select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> -	select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> -	select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> -	select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> +	select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> +	select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> +	select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> +	select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> +	select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> +	select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
>  	select USE_OF
>  	help
>  	  Select this to build a kernel which aims to support multiple boards,
> --=20
> 2.13.6
>=20
>=20

--CRrRoVXEpX/Dc4YP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlpfqiMACgkQbAtpk944
dnoQ4Q//bfwU5ov0Ge3GWNQDJEfZVOZF2QwBMPW7yg+c70OQHC0v9RFRdf6gwcdy
PKaTsbII9ZZv1zwDwJMFc5CS6elJLT8fpL8BdV1oQ/gH4/m1GzM357pNMypk6LQf
4s9Yp7E8k8mViik4TyZ9B2zCmRH1yG99KNVR7bEHCfvTgTp1uE6wFATPgyIzbtD8
p6jb/Fu2CxAluAcyw58qioxoLENu4n2pGHKXa9sJ0CFMCvAAGpfF2eH9q/1kNgZu
mc4zgucCKhv+PdhH0fWUM/NmW1wAPv4jOVQMblK9onFt4QnJe96aFtZp7JhpM2ae
EsEFWPNGqNJEm4ls2Nl63U4rXwmQ7/BSuLiHhPyP254cOXTGNi6kMjMnMPLCPG/+
shBO1GOLjD+kj0vIdJkq8gxKwc6Y7jjzbcH5VXPpbQhEk4198hXsMpo/uZ4nFWgD
H1nFU+UWW48ATBdY9d3p9rdowBMFmfbfNza8XpqN8TCb4dn41G7SMvtw3NAeSflY
Djlojqb/uWzbIoegcksNlpx5MzczkAJnLtIlume6GB2IpLYItpAMgbTMEKfe9BUj
otOBa//Kv+yyiSJ3zv4mlEREZuXjMqMhkcLkIACOgw6so5MiTZ+ytBqKy/Ma/jxx
usWugINdDpBafDsklidCSiYYzfuFkKvdt2u6xu42r13/uoEnJEM=
=kNim
-----END PGP SIGNATURE-----

--CRrRoVXEpX/Dc4YP--