Received: by 10.223.148.5 with SMTP id 5csp6452573wrq; Wed, 17 Jan 2018 14:03:07 -0800 (PST) X-Google-Smtp-Source: ACJfBouQ5VDj/7bGwRH3H4hcIh4hv1kN6F81BzppUAhOQ/CosN2EvIOwKFELX1mlYi8wTtwY2iBF X-Received: by 10.84.197.3 with SMTP id m3mr8599116pld.107.1516226587590; Wed, 17 Jan 2018 14:03:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516226587; cv=none; d=google.com; s=arc-20160816; b=sVsBPlRKS3OuM5uGPYiKc/iSLHvMcFdAMUSJfXPf1maqVepyPzt8iBnFfiedT2gUTt FzLQGeNxXxC7dzAEFly5xmplUpCI6qTTW5zyvdkfJ9AcqE+4uGrdPhCXH5WxwGPz58T0 s+b4+E8hu3ah+1FErv7qlX0HmjwVQqKN3UQBjuh+Q8NRelHop/tgluBCn2d9UoaqDWQm FHs1InC0BFEkIgBBGBqCNM+FMhs04F3Lyecuc/tul5F7Koo7TVQUXwD5XDHgbt34m4m6 nEPSF8R/Ej8wj4W1Qhds4GNdvVQJKajqi6gyqfRzp/0Zj4mPyxkK4zkE6khjIQJyxhd8 wIhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:cc:references:to:subject:arc-authentication-results; bh=0Qe+Cow3kXY1qTYTSJ7eguHo/QqNYtmZjLdvM6mGNKU=; b=rst7rCX0mQJyjdjQzRk/Fk95ThfoJqyKFdxI+UuTpr5yrIZQouPAl28Ur9V1NmNrVC SM8fBZDZwhn3a4LBOGD4wEzQ0FMGztOIK6XG8+UBhVQdM+0d8LRe6rwSfXhFLSj+4fnl uC3QvHJRL2AcvjKFoNGYmTleLaPey0CdM5lV8/43mF8H60UAoSE84v2hOfSHIHTrnVcL RYPn/+42ZGk+zHxRp/FgOotoJStbAYsvlOzM1v3VhVYh1Hx0v5LDWRfeRTMlRDSAD/RU jlw91kOQ30S+H2NqaB9qG7Mk8bVMrJVAbL1eDAqSgG3gXaTxNR0XlpqQ83kLC8Hry4rO L7jQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q10si4513055pgc.403.2018.01.17.14.02.53; Wed, 17 Jan 2018 14:03:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753764AbeAQWA5 (ORCPT + 99 others); Wed, 17 Jan 2018 17:00:57 -0500 Received: from mga01.intel.com ([192.55.52.88]:6875 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753702AbeAQWA4 (ORCPT ); Wed, 17 Jan 2018 17:00:56 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 14:00:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,374,1511856000"; d="scan'208";a="166956644" Received: from ray.jf.intel.com (HELO [10.7.201.126]) ([10.7.201.126]) by orsmga004.jf.intel.com with ESMTP; 17 Jan 2018 14:00:55 -0800 Subject: Re: [mm 4.15-rc8] Random oopses under memory pressure. To: Linus Torvalds , Tetsuo Handa References: <201801160115.w0G1FOIG057203@www262.sakura.ne.jp> <201801170233.JDG21842.OFOJMQSHtOFFLV@I-love.SAKURA.ne.jp> <201801172008.CHH39543.FFtMHOOVSQJLFO@I-love.SAKURA.ne.jp> Cc: "Kirill A. Shutemov" , Andrew Morton , Johannes Weiner , Joonsoo Kim , Mel Gorman , Tony Luck , Vlastimil Babka , Michal Hocko , Ingo Molnar , Linux Kernel Mailing List , linux-mm , the arch/x86 maintainers From: Dave Hansen Message-ID: <87aea433-ba6b-8543-d925-3ef36911f124@linux.intel.com> Date: Wed, 17 Jan 2018 14:00:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/17/2018 01:39 PM, Linus Torvalds wrote: > > So maybe something like this to test the theory? > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 76c9688b6a0a..f919a5548943 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -756,6 +756,8 @@ static inline void rmv_page_order(struct page *page) > static inline int page_is_buddy(struct page *page, struct page *buddy, > unsigned int order) > { > + if (WARN_ON_ONCE(page_zone(page) != page_zone(buddy))) > + return 0; > if (page_is_guard(buddy) && page_order(buddy) == order) { > if (page_zone_id(page) != page_zone_id(buddy)) > return 0; I thought that page_zone_id() stuff was there to prevent this kind of cross-zone stuff from happening.