Received: by 10.223.148.5 with SMTP id 5csp6687437wrq; Wed, 17 Jan 2018 17:32:59 -0800 (PST) X-Google-Smtp-Source: ACJfBouCXnIMXlfa2ia1O8RnfQu4C6vFQLBaTF3egwJU0mQNrfXf8H2cghLziQs583uUD2I4gzpB X-Received: by 10.84.128.106 with SMTP id 97mr40006375pla.73.1516239179614; Wed, 17 Jan 2018 17:32:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516239179; cv=none; d=google.com; s=arc-20160816; b=sFt0GzGFaIR6Zs1fHDAS+cw9oxfk3r8NnG+afFW1lf/qz7Kf6/p69RGCi6VsjcvIUp qHBURb0Ngrqn8U7WIS5QLt/nSqr4AnJS8s4SW3ac0QX9dWgDYwLY9+A8wYJA/ZfkUGix w2DhLlAdQrLxFGDJPfJLQ1YlEATu5K4L2V/YyQUWaaCmgTq6uKMjN8UIfItCcqUMoJer /+jJtqf6+7IEMha1AhbT/Fbutv8UUssNdXhfdGNnPO/hr34CcYk7cGnHNs+Emqcwb2se zdD1sNqGADNGKvipgySdVfL0vBEAOJwyPTg+ltDJ+h5Ldt+bOXo96nlTiw2M8M3ZgeKC nK9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=3wcc/Nm1v2iNFaaQ9JQGzWLa/EFz8+G7/+Ghzzbk0bo=; b=fBYTWgjLnK51r3BH66QjTr9+ESsh/yTgJwiXVzhQbvvKIseVHY5AopJ9L+OXr/dDno K9naW1fKj0uCg4V9iRClnEOZwPOqEc374INrw7Rx8Qgf/I1lqz/OpyjnEtXXt/2dN676 VvDJP+srRnnVwIdN9g8DOn97D3z4BA15/zw2+3mLvC7VRTB2b3Q65Gje3FG5uE/N1+aQ E4C3SnIqnH4tHlt/5jRSmHK80UstMam8488G1mjbkEJwEua2oDCBH4h7bAopYFiiPdyL UHrypOisESvvKaU80kl5smjER21LyCQsnAdLHogprospmmET8Q+d5mgX1E+xTHz0pdMW PFEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n10si3135983pgp.8.2018.01.17.17.32.45; Wed, 17 Jan 2018 17:32:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752588AbeARBcV (ORCPT + 99 others); Wed, 17 Jan 2018 20:32:21 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:41429 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbeARBcU (ORCPT ); Wed, 17 Jan 2018 20:32:20 -0500 Received: from 79.184.254.76.ipv4.supernova.orange.pl (79.184.254.76) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.82) id 0af30d9a3c0823c6; Thu, 18 Jan 2018 02:32:18 +0100 From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: Luis de Bethencourt , linux-kernel@vger.kernel.org, Joe Perches , Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH] PCI / PM: Fix trailing semicolon Date: Thu, 18 Jan 2018 02:30:59 +0100 Message-ID: <2146802.vfl1bvI4u7@aspire.rjw.lan> In-Reply-To: <20180117182149.GB7039@bhelgaas-glaptop.roam.corp.google.com> References: <20180117103321.24414-1-luisbg@kernel.org> <20180117182149.GB7039@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, January 17, 2018 7:21:49 PM CET Bjorn Helgaas wrote: > [+cc Rafael] > > On Wed, Jan 17, 2018 at 10:33:21AM +0000, Luis de Bethencourt wrote: > > The trailing semicolon is an empty statement that does no operation. > > Removing it since it doesn't do anything. > > > > Signed-off-by: Luis de Bethencourt > > Acked-by: Bjorn Helgaas > > Rafael, I have nothing queued for pci-driver.c, and you've merged most > of the recent changes there. If you have any pending changes to it, > feel free to merge this one. Otherwise, I'll be happy to pick it up. > > I would change the subject to: > > PCI / PM: Remove spurious semicolon OK, I'll take this one. Thanks, Rafael > > --- > > > > Hi, > > > > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches > > suggested I fix it treewide [0]. > > > > Best regards > > Luis > > > > > > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html > > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html > > > > drivers/pci/pci-driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > > index d79dbc377b9c..5958c8dda4e3 100644 > > --- a/drivers/pci/pci-driver.c > > +++ b/drivers/pci/pci-driver.c > > @@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev) > > if (dev_pm_smart_suspend_and_suspended(dev)) > > return 0; > > > > - return pm_generic_freeze_late(dev);; > > + return pm_generic_freeze_late(dev); > > } > > > > static int pci_pm_freeze_noirq(struct device *dev) >